[thermal_manager_base] Add a stop function to thermal manager #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Junchao-Mellanox LGTM . Can you please add unit test to cover this flow? |
|
Unit test case added. |
jleveque
approved these changes
May 10, 2021
jleveque
pushed a commit
to sonic-net/sonic-platform-daemons
that referenced
this pull request
May 10, 2021
Make thermalctld exit as soon as possible. Depends on sonic-net/sonic-platform-common#187 During config reload flow, supervisord sends SIGTERM to thermalctld. However, if thermalctld cannot exit in 10 seconds, supervisord sends SITKILL to thermalctld. In this case, sub process of thermalctld might still stay in memory as a zombie process. This PR is aimed to fix this.
qiluo-msft
pushed a commit
to sonic-net/sonic-platform-daemons
that referenced
this pull request
May 18, 2021
Make thermalctld exit as soon as possible. Depends on sonic-net/sonic-platform-common#187 During config reload flow, supervisord sends SIGTERM to thermalctld. However, if thermalctld cannot exit in 10 seconds, supervisord sends SITKILL to thermalctld. In this case, sub process of thermalctld might still stay in memory as a zombie process. This PR is aimed to fix this.
qiluo-msft
pushed a commit
that referenced
this pull request
May 24, 2021
Add a stop function to thermal manager. Allow thermalctld to call the stop function to stop run_policy function fast
andywongarista
pushed a commit
to andywongarista/sonic-platform-daemons
that referenced
this pull request
Jun 30, 2021
Make thermalctld exit as soon as possible. Depends on sonic-net/sonic-platform-common#187 During config reload flow, supervisord sends SIGTERM to thermalctld. However, if thermalctld cannot exit in 10 seconds, supervisord sends SITKILL to thermalctld. In this case, sub process of thermalctld might still stay in memory as a zombie process. This PR is aimed to fix this.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
…common classes (sonic-net#187) #### Description Existing test will mix true swsscommon package with the mocked one in sonic_py_common #### Motivation and Context This is blocking sonic-net/sonic-buildimage#7655 #### How Has This Been Tested? Unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a stop function to thermal manager
Motivation and Context
Allow thermalctld to call the stop function to stop run_policy function fast
How Has This Been Tested?
sonic-mgmt regression
Additional Information (Optional)