Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic_eeprom] Fix variable type #145

Merged
merged 1 commit into from
Nov 19, 2020
Merged

[sonic_eeprom] Fix variable type #145

merged 1 commit into from
Nov 19, 2020

Conversation

bratashX
Copy link
Contributor

@bratashX bratashX commented Nov 17, 2020 •
edited
Loading

Signed-off-by: Petro Bratash [email protected]

Fix crash in show version CLI command:

admin@sonic:~$ show version 
SONiC Software Version: SONiC.master.39-dirty-20201116.030425
Distribution: Debian 10.6
Kernel: 4.19.0-9-2-amd64
Build commit: e526d889
Build date: Mon Nov 16 06:49:50 UTC 2020
Built by: johnar@jenkins-worker-4Platform: x86_64-accton_wedge100bf_32x-r0
HwSKU: montara
ASIC: barefoot
Traceback (most recent call last):
  File "/usr/local/bin/decode-syseeprom", line 171, in <module>
    exit(main())
  File "/usr/local/bin/decode-syseeprom", line 47, in main
    t = class_('board', '','','')
  File "/usr/share/sonic/device/x86_64-accton_wedge100bf_32x-r0/plugins/eeprom.py", line 104, in __init__
    if self.eeprom_init():
  File "/usr/share/sonic/device/x86_64-accton_wedge100bf_32x-r0/plugins/eeprom.py", line 167, in eeprom_init
    new_e = eeprom_tlvinfo.TlvInfoDecoder.set_eeprom(self, "", [eeprom_params])
  File "/usr/local/lib/python2.7/dist-packages/sonic_eeprom/eeprom_tlvinfo.py", line 173, in set_eeprom
    (tlv_found, index) = self.get_tlv_index(new_tlvs, k)
  File "/usr/local/lib/python2.7/dist-packages/sonic_eeprom/eeprom_tlvinfo.py", line 454, in get_tlv_index
    if not self.is_valid_tlv(e[tlv_index:]):
  File "/usr/local/lib/python2.7/dist-packages/sonic_eeprom/eeprom_tlvinfo.py", line 255, in is_valid_tlv
    return (len(e) >= 2 and (2 + e[1] <= len(e)))
TypeError: unsupported operand type(s) for +: 'int' and 'str'
Serial Number:
............

@bratashX
Copy link
Contributor Author

@akokhan, please review

@bratashX
Copy link
Contributor Author

@jleveque, could you please review.

jleveque
jleveque approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jleveque jleveque merged commit 32ee007 into sonic-net:master Nov 19, 2020
@bratashX bratashX mentioned this pull request Nov 19, 2020
Merged
lguohan pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Nov 19, 2020
@bratashX
[sonic-platform-common] Update submodule (#5977)
d2f143d 
[sonic_eeprom] Fix variable type: sonic-net/sonic-platform-common#145

Signed-off-by: Petro Bratash <[email protected]>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@bratashX @santhosh-kt
[sonic-platform-common] Update submodule (sonic-net#5977)
6df5f7c 
[sonic_eeprom] Fix variable type: sonic-net/sonic-platform-common#145

Signed-off-by: Petro Bratash <[email protected]>
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
@vganesan-nokia
[voqinband]Support for inband port as regular port (sonic-net#145)
be7f4e1 
Signed-off-by: vedganes <[email protected]>

Inband port is avaialable in PORT table. But regular port handlings are
not applicable for Inband port. Changes in this PR are to avoid regular
port handling on Inband port for ledd script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akokhan akokhan akokhan approved these changes

@jleveque jleveque jleveque approved these changes

Assignees
No one assigned
Labels
Bug EEPROM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bratashX @jleveque @akokhan