Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The order of the SfpUtilHelper.logical ports list is broken #415

Closed
sheiun-xu opened this issue Dec 1, 2023 · 0 comments · Fixed by #416
Closed

The order of the SfpUtilHelper.logical ports list is broken #415

sheiun-xu opened this issue Dec 1, 2023 · 0 comments · Fixed by #416
Assignees
@mihirpat1
Labels
Bug

Comments

@sheiun-xu
Copy link
Contributor

sheiun-xu commented Dec 1, 2023 •
edited
Loading

be04b80 mutilasic platform support breaks the order

sonic-platform-common/sonic_platform_base/sonic_sfp/sfputilhelper.py

Line 93 in 2efe97e

self.logical = list(set(self.logical))

Use the function set(...) would break the original order of list

And this issue would also cause the sfputil show eeprom failed due to the order of the presence are miss matched with the port.
sheiun-xu added a commit to sheiun-xu/sonic-platform-common that referenced this issue Dec 1, 2023
@sheiun-xu
Fix the order of the SfpUtilHelper.logical (sonic-net#415)
36ed083
sheiun-xu added a commit to sheiun-xu/sonic-platform-common that referenced this issue Dec 1, 2023
@sheiun-xu
Fix the order of the SfpUtilHelper.logical (sonic-net#415)
9c8acae 
* Update test_read_port_mappings, test_read_all_port_mappings to
  check every port element to make sure the order is right
* Fix typo physical_to_logica -> physical_to_logical
@sheiun-xu sheiun-xu mentioned this issue Dec 1, 2023
Merged
@prgeor prgeor added the Bug label Dec 1, 2023
prgeor pushed a commit to sheiun-xu/sonic-platform-common that referenced this issue Dec 13, 2023
@sheiun-xu @prgeor
Fix the order of the SfpUtilHelper.logical (sonic-net#415)
9436364 
* Update test_read_port_mappings, test_read_all_port_mappings to
  check every port element to make sure the order is right
* Fix typo physical_to_logica -> physical_to_logical
prgeor pushed a commit that referenced this issue Dec 15, 2023
@sheiun-xu
Fix the order of the SfpUtilHelper.logical (#415) (#416)
0f72932 
* Update test_read_port_mappings, test_read_all_port_mappings to
  check every port element to make sure the order is right
* Fix typo physical_to_logica -> physical_to_logical
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihirpat1 mihirpat1

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the order of the SfpUtilHelper.logical (#415) sheiun-xu/sonic-platform-common
3 participants
@prgeor @sheiun-xu @mihirpat1