Skip to content

Commit

Permalink
[ChassisBase][ModuleBase] Remove redundant 'get_serial_number()' meth…
Browse files Browse the repository at this point in the history
…od (#130)

ChassisBase and ModuleBase inherit from the DeviceBase class, which already provides a get_serial() method. Thus, these methods were redundant.
  • Loading branch information
jleveque authored Oct 14, 2020
1 parent df61c55 commit ec9082e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
9 changes: 0 additions & 9 deletions sonic_platform_base/chassis_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,6 @@ def get_base_mac(self):
"""
raise NotImplementedError

def get_serial_number(self):
"""
Retrieves the hardware serial number for the chassis
Returns:
A string containing the hardware serial number for this chassis.
"""
raise NotImplementedError

def get_system_eeprom_info(self):
"""
Retrieves the full content of system EEPROM information for the chassis
Expand Down
9 changes: 0 additions & 9 deletions sonic_platform_base/module_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,6 @@ def get_base_mac(self):
"""
raise NotImplementedError

def get_serial_number(self):
"""
Retrieves the hardware serial number for the module
Returns:
A string containing the hardware serial number for this module.
"""
raise NotImplementedError

def get_system_eeprom_info(self):
"""
Retrieves the full content of system EEPROM information for the module
Expand Down

0 comments on commit ec9082e

Please sign in to comment.