Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced bgp_fact to validate NEIGH_STATE_TABLE element 'peerType' #8462

Merged
merged 24 commits into from
Jun 4, 2023

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented May 30, 2023

What I did:
Added validation for this change : sonic-net/sonic-buildimage#15265

How I verify : -
Manual Verification

added sleep after bgp shut to give enough time for route withdrawl

Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/bgp/test_bgp_fact.py:28:36: E127 continuation line over-indented for visual indent
tests/bgp/test_bgp_fact.py:30:31: E222 multiple spaces after operator

check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Abhishek Dosi <[email protected]>
@abdosi abdosi merged commit cfaa897 into sonic-net:master Jun 4, 2023
@abdosi
Copy link
Contributor Author

abdosi commented Jun 7, 2023

sonic-buildimage changes are present now in 202205.

@mssonicbld
Copy link
Collaborator

@abdosi PR conflicts with 202205 branch

abdosi added a commit to abdosi/sonic-mgmt that referenced this pull request Jun 13, 2023
wangxin pushed a commit that referenced this pull request Jun 14, 2023
…8462) (#8572)

Added validation for this change : sonic-net/sonic-buildimage#15265

Cherry-pick of PR: #8462 to 202205 branch.

Signed-off-by: Abhishek Dosi <[email protected]>
mrkcmo pushed a commit to Azarack/sonic-mgmt that referenced this pull request Oct 3, 2023
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants