Test case 1 of PFC watchdog against warm-reboot: happy path #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenda Ni <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
wendani
changed the title
wendani
changed the title
stepanblyschak
suggested changes
Jul 2, 2019
ansible/roles/test/tasks/pfc_wd/functional_test/functional_test_restore.yml
Show resolved
Hide resolved
ansible/roles/test/tasks/pfc_wd/functional_test/functional_test_storm.yml
Show resolved
Hide resolved
ansible/roles/test/tasks/pfc_wd/functional_test/functional_test_storm.yml
Show resolved
Hide resolved
or pfcwd warm-reboot test Signed-off-by: Wenda Ni <[email protected]>
stepanblyschak
suggested changes
Oct 2, 2019
ansible/roles/test/tasks/pfc_wd/functional_test/functional_test_warm_reboot.yml
Show resolved
Hide resolved
|
@wendani One additional small change requested. |
Signed-off-by: Wenda Ni <[email protected]>
|
Thx for prompt action. Let's move on to test case 2 once this one is set. #825 (comment) |
stcheng
approved these changes
Oct 4, 2019
yxieca
pushed a commit
that referenced
this pull request
Oct 7, 2019
* First test case of PFC watchdog against warm-reboot Signed-off-by: Wenda Ni <[email protected]> * Add more comments for code readability Signed-off-by: Wenda Ni <[email protected]> * Use boolean variable to determine the test run type: regular pfc wd test or pfcwd warm-reboot test Signed-off-by: Wenda Ni <[email protected]> * Feed reboot type to reboot_sonic.yml in warm-reboot happy path test Signed-off-by: Wenda Ni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce warm-reboot test path to current PFC watchdog test harness.
Add test case 1:
PFC storm detected and restored before warm-reboot
no on-going storm before warm-reboot emission
PFC storm detect and restore functional after warm-reboot
Infrastructure change:
Fine control PFC storm stop at fanout to allow per-queue per-port granularity
Tested on regular pfc watchdog without break.
Signed-off-by: Wenda Ni [email protected]
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation