Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test_buffer.py for cisco-8000 platforms. #7406

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Skip test_buffer.py for cisco-8000 platforms. #7406

merged 1 commit into from
Feb 8, 2023

Conversation

rraghav-cisco
Copy link
Contributor

@rraghav-cisco rraghav-cisco commented Feb 7, 2023

All tests in qos/test_buffer.py check for dynamic buffer model and then procede. Since cisco-8000 platform supports only traditional model, this does nothing, and spends a lot of time unnecessarily. This PR is to skip them at the entry level itself for cisco-8000 platforms.

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

To save time running on cisco-8000 platforms.

How did you do it?

Added skip condition in common skip condition yaml file.

How did you verify/test it?

Ran it with cisco platform:
--------------------------------------------------------------------------------------------------- live log sessionfinish ---------------------------------------------------------------------------------------------------
20:17:06 init.pytest_terminal_summary L0064 INFO | Can not get Allure report URL. Please check logs
================================================================================================== short test summary info ===================================================================================================
SKIPPED [1] qos/test_buffer.py:1991: These tests don't apply to cisco 8000 platforms, since they support only traditional model.
SKIPPED [16] qos/test_buffer.py: These tests don't apply to cisco 8000 platforms, since they support only traditional model.
================================================================================================= 17 skipped in 2.34 seconds =================================================================================================
vxr@02b4831febde:/data/tests$

Without this fix, we get 3 minutes to skip all:
<testsuite errors="0" failures="0" name="pytest" skipped="17" tests="17" time="164.315">

Any platform specific information?

Specific to cisco-8000 platforms only.

@rraghav-cisco
Copy link
Contributor Author

@kevinwangsk , pls check.

@abdosi abdosi merged commit 8fe06a4 into sonic-net:master Feb 8, 2023
kellyyeh pushed a commit to kellyyeh/sonic-mgmt that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants