Skip test_buffer.py for cisco-8000 platforms. #7406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests in qos/test_buffer.py check for dynamic buffer model and then procede. Since cisco-8000 platform supports only traditional model, this does nothing, and spends a lot of time unnecessarily. This PR is to skip them at the entry level itself for cisco-8000 platforms.
Back port request
Approach
To save time running on cisco-8000 platforms.
How did you do it?
Added skip condition in common skip condition yaml file.
How did you verify/test it?
Ran it with cisco platform:
--------------------------------------------------------------------------------------------------- live log sessionfinish ---------------------------------------------------------------------------------------------------
20:17:06 init.pytest_terminal_summary L0064 INFO | Can not get Allure report URL. Please check logs
================================================================================================== short test summary info ===================================================================================================
SKIPPED [1] qos/test_buffer.py:1991: These tests don't apply to cisco 8000 platforms, since they support only traditional model.
SKIPPED [16] qos/test_buffer.py: These tests don't apply to cisco 8000 platforms, since they support only traditional model.
================================================================================================= 17 skipped in 2.34 seconds =================================================================================================
vxr@02b4831febde:/data/tests$
Without this fix, we get 3 minutes to skip all:
<testsuite errors="0" failures="0" name="pytest" skipped="17" tests="17" time="164.315">
Any platform specific information?
Specific to cisco-8000 platforms only.