You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@OleksandrKozodoi Does this fix work for both python2 and python3?
I think this is compatibility issue introduced by #4867. For now, sonic-mgmt asks all the changes need to be both python2&3 compatible.
BTW, lambda has different behavior for py2 and py3, is it better to fix it in a common way such as using for loop to replace lambda? Then it could no more compatibility issue for this case. Thanks.
And map doesn't return list in python3, you have to turn it into list.
So, I suggest rewriting the code, don't use lambda and map. What do you think about it?
Hi @ZhaohuiS. You are right, this is compatibility issue introduced by #4867. I agree, that it is better to fix it by using a loop. Thanks for your suggestion!
Hi @ZhaohuiS. You are right, this is compatibility issue introduced by #4867. I agree, that it is better to fix it by using a loop. Thanks for your suggestion!
What is the motivation for this PR?
Fix the issue reported in #4867, failures: TypeError: () takes exactly 2 arguments (1 given)
The fix in #5605 still uses lambda which is not easy to read and may have compatibility issue.
How did you do it?
Use for loop and concentrate string together and append them to a list.
How did you verify/test it?
run tests/test_qos_sai.py
Signed-off-by: Zhaohui Sun <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: fixed startup of QoS SAI tests
Fixes # (issue)
QoS SAI tests fail with the error on ptfhost_utils.py:185 :
Fixed it
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix QoS SAI tests
How did you do it?
Fixed syntax issue in
mapfunc usageHow did you verify/test it?
py.test --inventory=../ansible/lab,../ansible/veos --testbed_file=../ansible/testbed.csv --module-path=../ansible/library -v -rA --topology=t1,any qos/test_qos_sai.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation