[advance-reboot] Fix sad case: don't send traffic through down lag interfaces #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shi-su
approved these changes
Nov 24, 2021
4 tasks
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
…terfaces (sonic-net#4758) Fix advance-reboot SAD cases in testcase test_warm_reboot_multi_sad. The cause for failure was when incorrect participating member interfaces in a LAG are selected. This issue supposedly started after sonic-net#3853 As part of PR 3853, some of the SAD case handling was moved out of ptf-tests. Due to this, the port selection for some cases is not done on ptf scripts. Specifically, presently the traffic is sent through even the LAGs which are brought down. This leads to part of the downstream traffic always being dropped - ultimately leading to warm-up failure.
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
…st (sonic-net#4776) Fix upgrade_path case: After fixing advance-reboot sad cases in sonic-net#4758, upgrade path cases have regressed. Update the param list for upgrade path cases same as in test_advanced_reboot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix sad case: don't send traffic through down lag interfaces
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix advance-reboot SAD cases in testcase
test_warm_reboot_multi_sad.The failures observed were:
The cause for failure was when incorrect participating member interfaces in a LAG are selected.
This issue supposedly started after #3853
As part of PR 3853, some of the SAD case handling was moved out of ptf-tests. Due to this, the port selection for some cases is not done on ptf scripts.
Specifically, presently the traffic is sent through even the LAGs which are brought down. This leads to part of the downstream traffic always being dropped - ultimately leading to warm-up failure.
How did you do it?
Select the right set of ports for test, and send I/O via these selected ports.
How did you verify/test it?
Tested on a physical testbed with the fix and the issue was not seen.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation