[Platform API]: Updates to make use of additional capabilities in pla… #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tform.json
The objective here is to extend the use of platform.json to allow a platform to
indicate whether or not specific HW features are supported.
Test cases modified:
- Component: skip firmware install and update test cases for Nokia platforms
- Fan Drawer: test_get_maximum_consumed_power
- PSU: test_power, test_temperature
- PSU Fans: handle case where no PSU fans are reported
- SFP: test_tx_disable_channel, test_power_override
- Thermal: test_get_low_threshold, test_get_high_threshold,
test_get_low_critical_threshold, test_get_high_critical_threshold,
test_set_low_threshold, test_set_high_threshold
|
@sujinmkang could you take a look on this PR 😃 |
sujinmkang
reviewed
Oct 22, 2021
| @@ -251,7 +251,7 @@ def test_get_fans_target_speed(self, duthosts, enum_rand_one_per_hwsku_hostname, | |||
| if fans_skipped == num_fans: | |||
| psus_skipped += 1 | |||
|
|
|||
| if psus_skipped == self.num_psus: | |||
| if num_fans != 0 and psus_skipped == self.num_psus: | |||
There was a problem hiding this comment.
each psu can have num_fans so shouldn't "num_fans != 0" is needed to move up above condition at line #251 "if fans_skipped == num_fans"?
There was a problem hiding this comment.
The intent of my change here is to deal with the case where psu.get_num_fans() returns 0 for each PSU. In this case I didn't want to report that all fans were skipped. Alternatively I could not count PSUs with no reported fans as skipped as you suggest. I will make that change.
sujinmkang
approved these changes
Oct 26, 2021
Blueve
approved these changes
Oct 26, 2021
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tform.json
The primary objective here is to extend the use of platform.json to allow a platform to
indicate whether or not specific HW features are supported. In addition, test cases not currently supported by Nokia platforms are skipped.
Test cases modified:
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Provide platform specific way to exclude unsupported HW features
How did you do it?
Enhance tests to consult platform.json file content to determine if feature is supported
How did you verify/test it?
Ran platform test suite
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation