Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vlan]: Dual ToR compatibility #3892

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

theasianpianist
Copy link
Contributor

@theasianpianist theasianpianist commented Jul 26, 2021

Signed-off-by: Lawrence Lee [email protected]

Description of PR

Summary:
Fixes sonic-net/sonic-buildimage#8236

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

VLAN test fails on Dual ToR testbeds

How did you do it?

  • Use minigraph-ptf-indices to obtain mapping from DUT port to PTF port
  • For dual ToR platforms, pick a single ToR for testing and make all ports active on that ToR (necessary since the test involves shutting down BGP sessions, so no IP-in-IP tunnel is available)
  • Clean up test setup and teardown

How did you verify/test it?

  • Run the test on a dual ToR and single ToR testbed, confirm that it passes

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@theasianpianist theasianpianist requested a review from a team as a code owner July 26, 2021 22:12
@theasianpianist theasianpianist marked this pull request as draft July 26, 2021 22:12
@lgtm-com
Copy link

lgtm-com bot commented Jul 26, 2021

This pull request introduces 1 alert when merging 4e6f945 into d8a3e87 - view on LGTM.com

new alerts:

  • 1 for Unused import

Signed-off-by: Lawrence Lee <[email protected]>
@theasianpianist theasianpianist marked this pull request as ready for review July 27, 2021 21:18
@theasianpianist theasianpianist merged commit 57ffe68 into sonic-net:master Jul 30, 2021
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
- Use minigraph-ptf-indices to obtain mapping from DUT port to PTF port
- For dual ToR platforms, pick a single ToR for testing and make all ports active on that ToR (necessary since the test - involves shutting down BGP sessions, so no IP-in-IP tunnel is available)
- Clean up test setup and teardown

Signed-off-by: Lawrence Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vlan] multiple failures on dual ToR
2 participants