Add test script for null_route_helper #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Jul 22, 2021
| assert(send_and_verify_packet(ptfadapter, pkt, exp_pkt, random.choice(ptf_t1_interfaces), rx_port, expected_result)) | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Remove extra empty lines #Closed
There was a problem hiding this comment.
Updated. Thanks
qiluo-msft
reviewed
Jul 22, 2021
| Build ipv4 and ipv6 packets/expected_packets for testing. | ||
| """ | ||
| pkt = None | ||
| exp_pkt = None |
There was a problem hiding this comment.
exp_pkt = None
You can remove the init lines? #Closed
There was a problem hiding this comment.
Updated. Thanks
Signed-off-by: bingwang <[email protected]>
bingwang-ms
force-pushed
the
null_route_helper_test
branch
from
470ea4b to
af2a244
Compare
Signed-off-by: bingwang <[email protected]>
qiluo-msft
approved these changes
Aug 2, 2021
|
Please hold on merging this PR until |
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
* Add test script for null_route_helper Signed-off-by: bingwang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang [email protected]
Description of PR
Summary:
PR sonic-net/sonic-utilities#1718 introduced a new helper script
null_route_helper. This PR is to implement test cases for the new script.Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to add test cases for
null_route_helperHow did you do it?
null_route_helperscript, and verify if packets are dropped or forwarded as expected.How did you verify/test it?
Verified on SN4600, T0 testbed.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Running on T0 topo.
Documentation