Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Snappi sample" #3766

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Revert "Snappi sample" #3766

merged 1 commit into from
Jul 12, 2021

Conversation

bingwang-ms
Copy link
Collaborator

Reverts #3653

This new script causes regression for almost all testbeds.

2021-07-11 07:00:31.791  
2021-07-11 07:00:31.791  ==================================== ERRORS ====================================
2021-07-11 07:00:31.791  _________________ ERROR collecting tests/snappi/test_snappi.py _________________
2021-07-11 07:00:31.792  ImportError while importing test module '/var/sonicbld/workspace/NewTests/TEMPLATE_PYTEST_T0_M4600C/tests/snappi/test_snappi.py'.
2021-07-11 07:00:31.792  Hint: make sure your test modules/packages have valid Python names.
2021-07-11 07:00:31.792  Traceback:
2021-07-11 07:00:31.792  snappi/test_snappi.py:7: in <module>
2021-07-11 07:00:31.792      from tests.common.snappi.snappi_fixtures import snappi_api_serv_ip, snappi_api_serv_port,\
2021-07-11 07:00:31.792  common/snappi/snappi_fixtures.py:5: in <module>
2021-07-11 07:00:31.792      import snappi
2021-07-11 07:00:31.792  E   ImportError: No module named snappi

@bingwang-ms bingwang-ms requested a review from a team as a code owner July 11, 2021 14:05
@bingwang-ms bingwang-ms mentioned this pull request Jul 11, 2021
2 tasks
@baiwei0427
Copy link
Contributor

Snappi should have been included in the latest sonic mgmt docker (https://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-sonic-mgmt/Dockerfile.j2#L45).

@wangxin
Copy link
Collaborator

wangxin commented Jul 12, 2021

Somehow, the sonic-mgmt docker used by nightly test does not include this package. We need to firstly unblock nightly testing by reverting this PR. Then we need to resolve the sonic-mgmt docker not up to date issue.

@bingwang-ms bingwang-ms merged commit 1b53581 into master Jul 12, 2021
@bingwang-ms bingwang-ms deleted the revert-3653-snappi_sample branch July 12, 2021 01:57
@bingwang-ms
Copy link
Collaborator Author

Snappi should have been included in the latest sonic mgmt docker (https://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-sonic-mgmt/Dockerfile.j2#L45).

Thanks. Please reopen the original PR once the sonic-mgmt is updated.

@ANISH-GOTTAPU
Copy link
Contributor

@wangxin & @bingwang-ms : I am not sure how to check the nightly test uses updated sonic-mgmt. Please let me know once it is updated, I will reopen the PR

neethajohn added a commit that referenced this pull request Jul 16, 2021
neethajohn added a commit that referenced this pull request Jul 21, 2021
This reverts commit 1b53581.

Reverts #3766 since the build is using the new docker
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
sonic-net#3806)

This reverts commit 1b53581.

Reverts sonic-net#3766 since the build is using the new docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants