BGP Convergence Test for Benchmark Performance #3715

selldinesh · 2021-06-29T00:43:28Z

Description of PR

Summary:BGP Convergence Test for Benchmark Performance
BGP Failover convergence for remote link failure
BGP RIB-IN Convergence
BGP RIB-IN Capacity
BGP Failover convergence for Local Link Failure
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

https://github.com/Azure/sonic-mgmt/blob/master/docs/testplan/BGP%20Convergence%20Testplan%20for%20single%20DUT.md#test-case--1--convergence-performance-when-remote-link-fails-route-withdraw

Get latest changes

lgtm-com · 2021-06-29T01:09:53Z

This pull request introduces 3 alerts when merging 13ff5fe18c2fabb7b8f624c54299d10b43bafd8c into ca982e6 - view on LGTM.com

new alerts:

3 for Unused import

lgtm-com · 2021-06-29T01:47:30Z

This pull request introduces 6 alerts when merging 8629730 into dff9522 - view on LGTM.com

new alerts:

6 for Unused import

wangxin · 2021-07-07T10:28:42Z

Can you fix the testing failures related with this change? It would be great if you can fix the LGTM alerts as well.

==================================== ERRORS ====================================
__________ ERROR collecting ixia/bgp/test_bgp_local_link_failover.py ___________
ImportError while importing test module '/var/src/s/tests/ixia/bgp/test_bgp_local_link_failover.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
ixia/bgp/test_bgp_local_link_failover.py:2: in <module>
    from tests.common.snappi.snappi_fixtures import cvg_api
common/snappi/snappi_fixtures.py:5: in <module>
    import snappi_convergence
E   ImportError: No module named snappi_convergence
__________ ERROR collecting ixia/bgp/test_bgp_remote_link_failover.py __________
ImportError while importing test module '/var/src/s/tests/ixia/bgp/test_bgp_remote_link_failover.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
ixia/bgp/test_bgp_remote_link_failover.py:1: in <module>
    from tests.common.snappi.snappi_fixtures import cvg_api
common/snappi/snappi_fixtures.py:5: in <module>
    import snappi_convergence
E   ImportError: No module named snappi_convergence
___________ ERROR collecting ixia/bgp/test_bgp_rib_in_convergence.py ___________
ImportError while importing test module '/var/src/s/tests/ixia/bgp/test_bgp_rib_in_convergence.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
ixia/bgp/test_bgp_rib_in_convergence.py:1: in <module>
    from tests.common.snappi.snappi_fixtures import cvg_api
common/snappi/snappi_fixtures.py:5: in <module>
    import snappi_convergence
E   ImportError: No module named snappi_convergence

selldinesh · 2021-07-12T07:22:11Z

@wangxin Raised a PR sonic-net/sonic-buildimage#8030 for snappi_convergence module

lgtm-com · 2021-07-12T17:38:56Z

This pull request introduces 3 alerts when merging ec60200 into 1b53581 - view on LGTM.com

new alerts:

2 for Unused local variable
1 for Variable defined multiple times

lgtm-com · 2021-07-13T20:31:21Z

This pull request introduces 1 alert when merging 20e20be into 1b53581 - view on LGTM.com

new alerts:

1 for Unused local variable

azure-pipelines · 2022-01-21T19:24:34Z

Azure Pipelines successfully started running 1 pipeline(s).

selldinesh · 2022-01-24T08:01:54Z

@wangxin can you please merge sonic-net/sonic-buildimage#9682.
This needs atleast one reviewer to approve, when this is fixed the statisticss import issue will be fixed

wangxin · 2022-01-25T02:33:49Z

PR sonic-net/sonic-buildimage#9682 has been merged, lets wait for a new sonic-mgmt docker image.

wangxin · 2022-02-07T11:12:49Z

/azp run

azure-pipelines · 2022-02-07T11:12:59Z

Azure Pipelines successfully started running 1 pipeline(s).

selldinesh · 2022-02-08T17:37:44Z

@wangxin I have updated the BGP scripts for the latest snappi version and raised a PR sonic-net/sonic-buildimage#9932 for snappi version 0.7.12 , can you please merge the PR 9932 and create a new sonic-mgmt docker image, after which the pipeline may pass

lgtm-com · 2022-02-08T18:14:13Z

This pull request introduces 1 alert when merging 89ece91 into 7a8be07 - view on LGTM.com

new alerts:

1 for Unnecessary pass

lgtm-com · 2022-02-11T22:38:49Z

This pull request introduces 1 alert when merging 326464e into 3acec36 - view on LGTM.com

new alerts:

1 for Unnecessary pass

mssonicbld · 2022-02-14T17:28:15Z

/AzurePipelines run

azure-pipelines · 2022-02-14T17:28:26Z

Azure Pipelines successfully started running 1 pipeline(s).

selldinesh · 2022-02-22T18:39:35Z

@wangxin The checks were successful before, now i see some checks are not successful, the results shows the test setup failure. Can this be resolved and merged

wangxin · 2022-02-23T05:17:55Z

@selldinesh I am not able to merge this PR until all tests passed. Lets give it another try.

wangxin · 2022-02-23T05:18:04Z

/azp run

azure-pipelines · 2022-02-23T05:18:13Z

Azure Pipelines successfully started running 1 pipeline(s).

lgtm-com · 2022-03-02T23:55:53Z

This pull request introduces 2 alerts when merging a4ec6a5 into f28a6c3 - view on LGTM.com

new alerts:

1 for Unnecessary pass
1 for Wrong number of arguments in a call

wangxin · 2022-03-16T04:07:51Z

tests/snappi/bgp/files/bgp_convergence_helper.py

@@ -941,5 +941,5 @@ def cleanup_config(duthost):
    duthost.command("sudo cp {} {}".format("/etc/sonic/config_db_backup.json","/etc/sonic/config_db.json"))
    duthost.shell("sudo config reload -y \n")
    logger.info("Wait until all critical services are fully started")
-    pytest_assert(wait_until(360, 10, 1, duthost.critical_services_fully_started), "Not all critical services are fully started")
+    pytest_assert(wait_until(360, 10, duthost.critical_services_fully_started), "Not all critical services are fully started")


I am afraid that this change won't work. The LGTM also raised alert "Wrong number of arguments in a call".

The wait_until function has been improved to support initial delay. Unfortunately the change is not backward compatible. The author has made a swept change. But all the open PRs still suffer from this issue.
This is the new signature of the wait_until function: https://github.com/Azure/sonic-mgmt/blob/master/tests/common/utilities.py#L82

For the wait_until to work in your local setup, can you do a rebase to the latest master branch and make a force push

@wangxin i have reverted the changes back for the wait_until function

selldinesh · 2022-03-16T19:56:52Z

/azpw run

mssonicbld · 2022-03-16T19:56:54Z

/AzurePipelines run

azure-pipelines · 2022-03-16T19:57:02Z

Azure Pipelines successfully started running 1 pipeline(s).

lgtm-com · 2022-03-16T20:18:52Z

This pull request introduces 1 alert when merging 2a47fcf into 5fecae8 - view on LGTM.com

new alerts:

1 for Unnecessary pass

selldinesh and others added 9 commits March 15, 2021 09:02

Merge pull request #2 from Azure/master

664aef8

Get latest changes

Merge branch 'Azure:master' into master

e527d1f

Merge branch 'Azure:master' into master

c773979

Adding BGP Benchmark testplan and test scripts

8e73e0f

Merge branch 'Azure:master' into master

265a81e

snappi 4.12 changes

914cc50

Test steps

a7659d0

Merge branch 'Azure:master' into master

3b066da

snappi-0.4.14 changes

33a7d0b

selldinesh requested review from wangxin, yxieca and a team as code owners June 29, 2021 00:43

Adding snappi fixtures

8629730

selldinesh force-pushed the bgp_convergence branch from 13ff5fe to 8629730 Compare June 29, 2021 01:16

selldinesh added 5 commits June 29, 2021 03:20

Resolving unused imports

689d51e

using snappi_api_serv_* fixtures

693a8fc

v6 routes support

b05bf49

v6 support

bcd03b7

try except block for interface configuration

489fff1

linter and snappi-0.4.16 changes

ec60200

selldinesh added 4 commits July 12, 2021 21:25

removing unused variables

9f70680

Adding RIB-IN capacity test

39da3fc

final changes

96f4c7c

Doc changes

20e20be

modified for snappi 0.7.12 version

89ece91

selldinesh added 2 commits February 11, 2022 21:48

As-Path additions

c3ac9de

snappi fixture modification

326464e

changing wait_until arguments

a4ec6a5

baiwei0427 previously approved these changes Mar 11, 2022

View reviewed changes

wangxin requested changes Mar 16, 2022

View reviewed changes

changing the arguments for wait_until function call

2a47fcf

selldinesh dismissed baiwei0427’s stale review via 2a47fcf March 16, 2022 19:55

wangxin approved these changes Mar 17, 2022

View reviewed changes

wangxin merged commit ef24e06 into sonic-net:master Mar 17, 2022

wsycqyz mentioned this pull request Aug 6, 2024

Need new test: BGP-Convergence #3608

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BGP Convergence Test for Benchmark Performance #3715

BGP Convergence Test for Benchmark Performance #3715

selldinesh commented Jun 29, 2021 •

edited

Loading

lgtm-com bot commented Jun 29, 2021

lgtm-com bot commented Jun 29, 2021

wangxin commented Jul 7, 2021

selldinesh commented Jul 12, 2021

lgtm-com bot commented Jul 12, 2021

lgtm-com bot commented Jul 13, 2021

azure-pipelines bot commented Jan 21, 2022

selldinesh commented Jan 24, 2022

wangxin commented Jan 25, 2022

wangxin commented Feb 7, 2022

azure-pipelines bot commented Feb 7, 2022

selldinesh commented Feb 8, 2022

lgtm-com bot commented Feb 8, 2022

lgtm-com bot commented Feb 11, 2022

mssonicbld commented Feb 14, 2022

azure-pipelines bot commented Feb 14, 2022

selldinesh commented Feb 22, 2022

wangxin commented Feb 23, 2022

wangxin commented Feb 23, 2022

azure-pipelines bot commented Feb 23, 2022

lgtm-com bot commented Mar 2, 2022

wangxin Mar 16, 2022 •

edited

Loading

selldinesh Mar 16, 2022

selldinesh commented Mar 16, 2022

mssonicbld commented Mar 16, 2022

azure-pipelines bot commented Mar 16, 2022

lgtm-com bot commented Mar 16, 2022

BGP Convergence Test for Benchmark Performance #3715

BGP Convergence Test for Benchmark Performance #3715

Conversation

selldinesh commented Jun 29, 2021 • edited Loading

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

lgtm-com bot commented Jun 29, 2021

lgtm-com bot commented Jun 29, 2021

wangxin commented Jul 7, 2021

selldinesh commented Jul 12, 2021

lgtm-com bot commented Jul 12, 2021

lgtm-com bot commented Jul 13, 2021

azure-pipelines bot commented Jan 21, 2022

selldinesh commented Jan 24, 2022

wangxin commented Jan 25, 2022

wangxin commented Feb 7, 2022

azure-pipelines bot commented Feb 7, 2022

selldinesh commented Feb 8, 2022

lgtm-com bot commented Feb 8, 2022

lgtm-com bot commented Feb 11, 2022

mssonicbld commented Feb 14, 2022

azure-pipelines bot commented Feb 14, 2022

selldinesh commented Feb 22, 2022

wangxin commented Feb 23, 2022

wangxin commented Feb 23, 2022

azure-pipelines bot commented Feb 23, 2022

lgtm-com bot commented Mar 2, 2022

wangxin Mar 16, 2022 • edited Loading

Choose a reason for hiding this comment

selldinesh Mar 16, 2022

Choose a reason for hiding this comment

selldinesh commented Mar 16, 2022

mssonicbld commented Mar 16, 2022

azure-pipelines bot commented Mar 16, 2022

lgtm-com bot commented Mar 16, 2022

selldinesh commented Jun 29, 2021 •

edited

Loading

wangxin Mar 16, 2022 •

edited

Loading