-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pfc tests migration from abstract to snappi #3641
Conversation
update to master
updating the name
updating to master repo
merging master
Routing Policy Tests
Revert "Routing Policy Tests"--reverting the PR to clean the master
This pull request introduces 1 alert when merging 903b055 into 4309468 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging cf37111 into 4327148 - view on LGTM.com new alerts:
|
@@ -0,0 +1,425 @@ | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is also created in #3653
@@ -0,0 +1,74 @@ | |||
import pytest | |||
import random | |||
from tests.common.ixia.common_helpers import enable_packet_aging, start_pfcwd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use tests.common.snappi.common_helpers instead.
fanout_graph_facts | ||
from tests.common.fixtures.snappi_fixtures import snappi_api_serv_ip, snappi_api_serv_port,\ | ||
snappi_api, tgen_testbed_config | ||
from tests.common.ixia.qos_fixtures import prio_dscp_map, all_prio_list, lossless_prio_list,\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ixia -> snappi
|
||
from files.helper import run_pfc_test | ||
|
||
pytestmark = [pytest.mark.topology('tgen')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pytest.mark.topology("snappi")
fanout_graph_facts | ||
from tests.common.fixtures.snappi_fixtures import snappi_api_serv_ip, snappi_api_serv_port,\ | ||
snappi_api, tgen_testbed_config | ||
from tests.common.ixia.qos_fixtures import prio_dscp_map, all_prio_list, lossless_prio_list,\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ixia -> snappi
|
||
logger = logging.getLogger(__name__) | ||
|
||
pytestmark = [pytest.mark.topology('tgen')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tgen -> snappi
fanout_graph_facts | ||
from tests.common.fixtures.snappi_fixtures import snappi_api_serv_ip, snappi_api_serv_port,\ | ||
snappi_api, tgen_testbed_config | ||
from tests.common.ixia.qos_fixtures import prio_dscp_map, all_prio_list, lossless_prio_list,\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ixia -> snappi
|
||
logger = logging.getLogger(__name__) | ||
|
||
pytestmark = [pytest.mark.topology('tgen')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tgen -> snappi
@baiwei0427 : This PR was raised before test_snappi, once test_snappi is merged, I will pull the master and update this PR accordingly |
Thanks! Please change all 'ixia' and 'tgen' to 'snappi' |
closing this as it is addressed in #3794 |
Description of PR
Migration of PFC tests from
ixnetwork-open-traffic-generator
tosnappi
Summary:
Test case(new/improvement)
Type of change
Approach
What is the motivation for this PR?
The motivation for this PR is to migrate the tests that are written with
ixnetwork open traffic generator
tosnappi
How did you do it?
Replaced the code where abstract is used to snappi
How did you verify/test it?
verified all the tests in sonic-mgmt using pytest with DUT and IXIA connections
snappi version used for the development of tests
snappi[ixnetwork]==0.4.1