Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase length of t0 portchannel interface name #358

Merged
merged 1 commit into from
Nov 18, 2017
Merged

increase length of t0 portchannel interface name #358

merged 1 commit into from
Nov 18, 2017

Conversation

maggiemsft
Copy link
Contributor

@jleveque
Copy link
Contributor

To add detail to this PR: This PR helps test the maximum length of interface name (15 chars in Linux, as IFNAMSIZ is defined as 16 bytes, which also includes a trailing NUL char). This will hopefully help catch future corner-case issues like we recently found with isc-dhcp (fixed here: sonic-net/sonic-buildimage#1164).

@lguohan lguohan merged commit 2aebedc into sonic-net:master Nov 18, 2017
@maggiemsft maggiemsft deleted the masun/minigraph_template branch November 21, 2017 04:26
praveen-li pushed a commit to praveen-li/sonic-mgmt that referenced this pull request Jun 20, 2019
Merge remote-tracking branch 'msft_github/master'
9284fef 
* msft_github/master:
  Update README.testbed.Setup.md
  call test by test case name (sonic-net#362)
  [testbed] fanout add rootfanout connect when deploying fanout switch (sonic-net#368)
  [lag_2] enable lag_2 test on t0-116 topology (sonic-net#390)
  [deployment] add missing quotation marks that breaks (sonic-net#386)
  Finalize T0-116 topology (sonic-net#381)
  Directed broadcast Test (sonic-net#377)
  [change_mac]: Change MAC address formatting (sonic-net#380)
  add github template helping report issues and submit pull request (sonic-net#378)
  Fixing logic to identify proper 'port_config.ini' file. (sonic-net#376)
  [sensors] add sensor definitions for arista 7260/7060 (sonic-net#371)
  [pfc_wd]: Rework for P2 (sonic-net#363)
  [test]: Update BGP speaker test (sonic-net#236)
  Add vm_resument which restore paused VMs (sonic-net#297)
  Copy acsbase files to ptf before ptf_runner (sonic-net#366)
  Modify dhcp_servers IPs in order to fix DHCP relay test (sonic-net#364)
  [templates]: Remove trailing space in t1-lag minigraph template (sonic-net#360)
  [fastreboot test]: Add "fanout_listener" for MLNX fanout switches (sonic-net#353)
  patch t0 portchannel name to 15 chars (sonic-net#358)
  [process_checker]: Add the process_checker playbook (sonic-net#349)
  fix issue 354 (sonic-net#355)
  Update build instruction for docker-ptf.gz and docker-sonic-mgmt.gz
  [upgrade_sonic]: Add upgrade_sonic as a convenience script to upgrade the device with an image (sonic-net#338)
  [acl test]: Generate switch info file. (sonic-net#346)
  fix t0 templates for generate minigraph (sonic-net#344)
  [loganalyzer_end.yml]: Rename expected_matches (sonic-net#345)
  [minigraph_facts]: Add the missing brace (sonic-net#342)
  [Arista7260cx3] update topology t0-116 to include port 17 and 19 (sonic-net#340)
  [fdb test] help switch populate mac table before starting the test (sonic-net#341)
  [arista7260cx3] include port 18 and 20 as 50G breakout ports (sonic-net#339)
  Loganalyzer enhancements (sonic-net#321)
  [plugin]: Adding Dell platform in switch connection plugin (sonic-net#333)
  modified files to get lag members from minigraph (sonic-net#327)
  [minigraph] modify script to fit the latest configuration method (sonic-net#331)
  [minigraph_fact] add port mapping for 5 INGRASYS switches (sonic-net#336)
  [sensors] add sensor data for 5 INGRASYS switches (sonic-net#335)
  [minigraph-template]: Add ACL L3 and mirroring tables to minigraph template. (sonic-net#330)
  [acltb-test]: Addopt ACL test to acl-loader. (sonic-net#299)
  [everflow test]: Addopt Everflow testbed test to acl-loader. (sonic-net#300)
  Remove hard-coded bgp speaker asn number, fetch from DUT (sonic-net#329)
  Port alias mapping added for Arista-7060CX-32S-C32 (sonic-net#328)
  Adding if case for S6100 platform to get port details (sonic-net#314)
  [interface_facts] improve interface facts checking performance (sonic-net#326)
  [fdb] Hard code port layout to enable fdb test on t0-116 topology (sonic-net#322) (sonic-net#320)
  [fib] Hard code port layout to enable fib test on t0-116 topology (sonic-net#322)
  [fib, fdb] Allow fib and fdb test info files to contain empty lines and comments (sonic-net#323)
  [lag_test]: Correct typo error for lag tests (sonic-net#325)
  [link flap test] improve performance of link flap test (sonic-net#319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@jleveque jleveque jleveque approved these changes

@stcheng stcheng Awaiting requested review from stcheng

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maggiemsft @jleveque @lguohan @stcheng