Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Use correct inventory file in CLI for deploying minigraph for VS seup #3195

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Conversation

wangxin
Copy link
Collaborator

@wangxin wangxin commented Mar 24, 2021

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

In current document for VS setup:
https://github.com/Azure/sonic-mgmt/blob/master/docs/testbed/README.testbed.VsSetup.md

Inventory file name lab is used in the example command line for deploying minigraph to VS setup:
$ ./testbed-cli.sh -t vtestbed.csv -m veos_vtb deploy-mg vms-kvm-t0 lab password.txt

The correct inventory file name for VS setup should be veos_vtb:
$ ./testbed-cli.sh -t vtestbed.csv -m veos_vtb deploy-mg vms-kvm-t0 veos_vtb password.txt

How did you do it?

Update inventory file name in example command line.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

In current document for VS setup:
https://github.com/Azure/sonic-mgmt/blob/master/docs/testbed/README.testbed.VsSetup.md

Inventory file name `lab` is used in the example command line for deploying minigraph to VS setup:
    $ ./testbed-cli.sh -t vtestbed.csv -m veos_vtb deploy-mg vms-kvm-t0 lab password.txt

The correct inventory file name for VS setup should be `veos_vtb`:
    $ ./testbed-cli.sh -t vtestbed.csv -m veos_vtb deploy-mg vms-kvm-t0 veos_vtb password.txt

Signed-off-by: Xin Wang <[email protected]>
@wangxin wangxin requested a review from a team March 24, 2021 02:38
@wangxin wangxin requested a review from yxieca as a code owner March 24, 2021 02:38
@wangxin wangxin merged commit 28ca9ef into sonic-net:master Mar 25, 2021
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
…c-net#3195)

In current document for VS setup:
https://github.com/Azure/sonic-mgmt/blob/master/docs/testbed/README.testbed.VsSetup.md

Inventory file name `lab` is used in the example command line for deploying minigraph to VS setup:
    $ ./testbed-cli.sh -t vtestbed.csv -m veos_vtb deploy-mg vms-kvm-t0 lab password.txt

The correct inventory file name for VS setup should be `veos_vtb`:
    $ ./testbed-cli.sh -t vtestbed.csv -m veos_vtb deploy-mg vms-kvm-t0 veos_vtb password.txt

Signed-off-by: Xin Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants