Enhance acl test case for multi-asic platforms #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
|
This pull request introduces 1 alert when merging 02d90a5 into b1c4f28 - view on LGTM.com new alerts:
|
Signed-off-by: Abhishek Dosi <[email protected]>
wangxin
reviewed
Mar 26, 2021
wangxin
approved these changes
Mar 29, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Enhance ACL test itself to run on multi-asic platforms. acl_table_ports will have port binding for each namespace. Updated mg_facts() library to associate External Port-Channel to namespace Updated interface_facts() to return data from all namespace/asic's on multi-asic platforms. Update port_toggle() utility to work for multi-asic/namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why I did:
This PR is continuation of #2514 where infra changes were done to support acl counters library for multi-asic platforms. Following changes are done here:
acl_table_portswill have port binding for each namespace.mg_facts()library to associate External Port-Channel to namespaceinterface_facts()to return data from all namespace/asic's on multi-asic platforms.port_toggle()utility to work for multi-asic/namespace.How I verify:
Verified both Single and Multi-asic platforms.