[tacacs] Skip ipintutil check on older OS versions #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Allen <[email protected]>
yxieca
reviewed
Mar 16, 2021
yxieca
approved these changes
Mar 16, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Signed-off-by: Danny Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen [email protected]
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Fixes #3116 and unblocks buildimage PRs.
How did you do it?
Interestingly, if a file exists in the
sudoersfile but does not exist on the system, we still see the following error:So we need to be sure that the commands we test here actually exist in the image. Because skipping over scripts that are not found on the system may actually mask issues as well, I have opted to include an explicit version check in the test code.
How did you verify/test it?
Re-ran the
ro_user_allowed_commandtest case against the 201911 and 202012 images.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation