[devutils] skip ping action if ansible_host is missing #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Xie <[email protected]>
vaibhavhd
approved these changes
Mar 15, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
approved these changes
Mar 17, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Approach What is the motivation for this PR? devutils will generate exception when ping'ing hosts that doesn't have ansible_host attribute. How did you do it? skip ping action for these hosts that don't have ansible_host attribute. How did you verify/test it? ping all hosts in an inventory contains hosts have no ansible_host attribute. Signed-off-by: Ying Xie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Type of change
Approach
What is the motivation for this PR?
devutils will generate exception when ping'ing hosts that doesn't have ansible_host attribute.
How did you do it?
skip ping action for these hosts that don't have ansible_host attribute.
How did you verify/test it?
ping all hosts in an inventory contains hosts have no ansible_host attribute.