Cleanup cache before run pytest in run_tests.sh #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only really less frequently changed content is cached. Although It is rare that cached content is inaccurate, it still could happen. Then it would be difficult to debug. This change added code in run_tests.sh to cleanup cache before running pytest. Without cached content, executing the first script may need extra time to gather facts again, but executing subsequent scripts still can benefit from content cached while executing the first script. Signed-off-by: Xin Wang <[email protected]>
lolyu
reviewed
Mar 12, 2021
| @@ -90,6 +90,8 @@ function setup_environment() | |||
| export ANSIBLE_CONFIG=${BASE_PATH}/ansible | |||
| export ANSIBLE_LIBRARY=${BASE_PATH}/ansible/library/ | |||
| export ANSIBLE_CONNECTION_PLUGINS=${BASE_PATH}/ansible/plugins/connection | |||
|
|
|||
| rm -fr ${BASE_PATH}/tests/_cache | |||
There was a problem hiding this comment.
I'm thinking about add logs to the decorator cached to make test user aware of where the facts come from(cached or function call).
lolyu
approved these changes
Mar 12, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
approved these changes
Mar 12, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Only really less frequently changed content is cached. Although It is rare that cached content is inaccurate, it still could happen. Then it would be difficult to debug.
How did you do it?
This change added code in run_tests.sh to cleanup cache before running pytest. Without cached
content, executing the first script may need extra time to gather facts again, but executing
subsequent scripts still can benefit from content cached while executing the first script.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation