[topo_facts]: Modify the 'type' argument used #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid overriding python 'type' function. Signed-off-by: Suvarna Meenakshi <[email protected]>
wangxin
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[topo_facts]: Modify the 'type' argument used to 'neigh_type' to
avoid overriding python 'type' function.
Signed-off-by: Suvarna Meenakshi [email protected]
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
#3024 introduced a new function with an argument called 'type'.
This will override existing python 'type' function. To avoid this, modify the argument name to 'neigh_type'
which can be 'VMs' or 'NEIGH_ASIC' based on the topo file being parsed.
How did you do it?
Modify the argument name to 'neigh_type'.
How did you verify/test it?
Bring up single-asic and multi-asic VS testbed with this change.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation