Change to use asic_instance() API in all test cases #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <[email protected]>
sonic-net#3103 Signed-off-by: Abhishek Dosi <[email protected]>
neethajohn
reviewed
Mar 9, 2021
Signed-off-by: Abhishek Dosi <[email protected]>
neethajohn
approved these changes
Mar 9, 2021
judyjoseph
approved these changes
Mar 9, 2021
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
changed the title
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
neethajohn
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially we had two set of API doing same thing
get_asic()andasic_instance().As part of https://github.com/Azure/sonic-mgmt/pull/3070/files#diff-ac7113ac4afb15af99807b123d079536d87e66389eab665362b294e2a760fa24L2382
change was made
get_asic()to return sonichost if asic Index is none. (this is needed if we want to run something on host for multi-asic platfroms). This change cause some of platform test to fail on single-asic platfroms since they were calling API's present in Asic host but not in Sonic host.With this PR made following changes:
Use
asic_instance()to always return ASIC objectRename
get_asic()toget_asic_or_sonic_host()which will return sonic host if asic_index is None else return asic host object. This API is useful if we want to execute/run something on host as well on asic in multi-asic platformsUpdated all the testcases to use correct set of API's.
Fix the issue
#3103
How I verify:
On Single Asic no exception is found.