Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vrf] Change test_vrf topology marker to t0 #3066

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

AndriiLozovyi
Copy link
Contributor

Signed-off-by: Andrii-Yosafat Lozovyi [email protected]

Description of PR

Summary: Goal of this PR is to set correct topology marker for test_vrf, for some reason topology is marked as any, although it is not correct if to compare with vrf test_plan which points that vrf test_cases should run on t0 topo. When run on t1, all tests cases fail on setup due to "KeyError: 'VLAN_MEMBER'".

ERROR    test_vrf:test_vrf.py:381 Exception raised in setup: KeyError('VLAN_MEMBER',)                                                                                    
ERROR    test_vrf:test_vrf.py:381 [                                                                                                                                      
  "Traceback (most recent call last):\n",                                                                                                                                
  "  File \"/var/user/jenkins/sonic-mgmt/tests/vrf/test_vrf.py\", line 381, in setup_vrf\n    setup_vrf_cfg(duthost, localhost, cfg_t0)\n",                              
  "  File \"/var/user/jenkins/sonic-mgmt/tests/vrf/test_vrf.py\", line 243, in setup_vrf_cfg\n    ports = get_vlan_members('Vlan1000', cfg_facts)\n",                    
  "  File \"/var/user/jenkins/sonic-mgmt/tests/vrf/test_vrf.py\", line 47, in get_vlan_members\n    for m in cfg_facts['VLAN_MEMBER'].keys():\n",                        
  "KeyError: 'VLAN_MEMBER'\n"                                                                                                                                            
]   

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Set correct topo marker for test_vrf, to prevent users from running test on a not supported topology.

How did you do it?

Change topo marker to t0

How did you verify/test it?

Run test_vrf on t0 and t1 topo

Any platform specific information?

SONiC.master.134-dirty-20210225.033210
Distribution: Debian 10.8
Kernel: 4.19.0-12-2-amd64
Build commit: 2a339faf
Build date: Thu Feb 25 10:55:43 UTC 2021
Built by: johnar@worker-sbc3a50
Platform: x86_64-accton_wedge100bf_32x-r0
HwSKU: montara

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Andrii-Yosafat Lozovyi <[email protected]>
@AndriiLozovyi AndriiLozovyi requested a review from a team as a code owner March 1, 2021 12:51
@wangxin wangxin merged commit 675a2b0 into sonic-net:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants