[VM]: Support SONiC VM on the server #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ze Gan <[email protected]>
lguohan
reviewed
Feb 26, 2021
| <name>{{ vm_name }}</name> | ||
| <memory unit='KiB'>3072000</memory> | ||
| <currentMemory unit='KiB'>3072000</currentMemory> | ||
| <vcpu placement='static'>4</vcpu> |
There was a problem hiding this comment.
do we need 4 cores per sonic vm or we can reduce to 2 cores?
lguohan
reviewed
Feb 26, 2021
| @@ -0,0 +1,54 @@ | |||
| <domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'> | |||
| <name>{{ vm_name }}</name> | |||
| <memory unit='KiB'>3072000</memory> | |||
There was a problem hiding this comment.
can we reduce the memory requirement to 2gb?
wangxin
reviewed
Feb 26, 2021
|
BTW, can you update the document (https://github.com/Azure/sonic-mgmt/blob/master/docs/testbed/README.testbed.VsSetup.md) as well? |
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
Pterosaur
changed the title
Pterosaur
requested review from
wangxin and
lguohan
and removed request for
a team
lguohan
approved these changes
Mar 3, 2021
|
lgtm |
wangxin
approved these changes
Mar 4, 2021
lguohan
added a commit
to lguohan/sonic-mgmt
that referenced
this pull request
Aug 16, 2021
disk_image_dir and cdrom_image should not contain home_path as the root_path can be absolute path. the issue is seem only when configure root_path as absolute path. bug was introduced in sonic-net#3036 Signed-off-by: Guohan Lu <[email protected]>
4 tasks
lguohan
added a commit
that referenced
this pull request
Aug 16, 2021
disk_image_dir and cdrom_image should not contain home_path as the root_path can be absolute path. the issue is seem only when configure root_path as absolute path. bug was introduced in #3036 Signed-off-by: Guohan Lu <[email protected]>
lolyu
pushed a commit
to lolyu/sonic-mgmt
that referenced
this pull request
Aug 18, 2021
disk_image_dir and cdrom_image should not contain home_path as the root_path can be absolute path. the issue is seem only when configure root_path as absolute path. bug was introduced in sonic-net#3036 Signed-off-by: Guohan Lu <[email protected]>
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
disk_image_dir and cdrom_image should not contain home_path as the root_path can be absolute path. the issue is seem only when configure root_path as absolute path. bug was introduced in sonic-net#3036 Signed-off-by: Guohan Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ze Gan [email protected]
Description of PR
The VEOS cannot support MACsec feature, so to make SONiC VM as the testbed servers is useful for testing some scenarios, like MACsec. This PR improves some ansible playbooks to start/stop SONiV VM.
Type of change
Approach
What is the motivation for this PR?
Some features aren't supported by the default VM image, VEOS.
How did you do it?
Add a switch
vm_typein some ansible playbooks to choose the VM os tosonicorveos.How did you verify/test it?
Follow this document: README.testbed.VsSetup.md
sonic-vs.imgin~/veos-vm/images/-k sonicon this the Setup Arista VMs on the server, like./testbed-cli.sh -m veos_vtb -n 4 -k sonic start-vms server_1 password.txt.ansible -m ping -i veos_vtb server_1 -u admin -kwith passwordpassword./testbed-cli.sh -m veos_vtb -n 4 -k sonic stop-vms server_1 password.txtAny platform specific information?
None
Supported testbed topology if it's a new test case?
None
Documentation
docs/testbed/README.testbed.VsSetup.md