[Platform API] Remove bounds check for thermal values #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request contains merge conflicts. |
|
/Azurepipelines run |
|
Pull request contains merge conflicts. |
|
@zzhiyuan: Please fix conflicts. |
zzhiyuan
force-pushed
the
boundscheck
branch
from
85abb6d to
63e46ac
Compare
Done. |
jleveque
approved these changes
Feb 18, 2021
jleveque
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes platform API test failure due to thermals with low thresholds too low or high thresholds too high.
Thermals vary vastly with low bounds being -55 or lower, and high bounds with 115 or higher. It's hard to set a good threshold while still making the test useful.
Type of change
Approach
What is the motivation for this PR?
In Arista's testing we found thermal sensors that do not conform to existing checks.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation