-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QoS] Update QoS pytests to use the multi-ASIC framework. #2993
Conversation
This pull request introduces 3 alerts when merging 9da5f83 into 5ed5cab - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you have the PR for the portchannel support in sai_qos, please update the description of this PR to include that info
This pull request introduces 1 alert when merging 8df4655 into b0890db - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 8f92224 into 63c3781 - view on LGTM.com new alerts:
|
Summary:
Update QoS pytests to use the multi ASIC framework.
Major changes:
NOTE: The changes here do not add new functionality or alter current logic. The changes are in preparation to run QoS tests on each ASIC independently on multi ASIC platforms.
Minor changes:
SSH tunnel:
This is a new API required to establish RPC tunnel between host namespace and the ASIC namespace on multi-ASIC platforms. QoS SAI tests use syncd RPC binary and use thrift APIs to to set/get port parameters. Thrift server port is constant across all namespaces. SAI tests use management IP and thrift port to communicate with thrift server. On a multi ASIC platform thrift server ports are opened in their respective namespaces. To facilitate communication with pytests, ssh tunnel is created between host namespace and the asic namespace on which test will run.
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Support QoS/PFC tests on multi-ASIC platforms. Ability to run QoS tests on each ASIC independently.
How did you do it?
Use 'asic index' fixture to generate tests per ASIC.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation