Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snmp] Added new snmp test case #2963

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

AndriiLozovyi
Copy link
Contributor

Signed-off-by: Andrii-Yosafat Lozovyi [email protected]

Description of PR

Summary: This PR implements a new test case test_snmp_v2mib according to the following test plan.
Test should verify that SNMPv2-MIB objects are functioning properly.
Fixes # (issue)

Testplan:

  • Retrieve facts for a device using SNMP
  • Get expected values for a device from system
  • Compare that facts received by SNMP are equal to values received from system

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

This PR is to add a new test case for snmp.

How did you do it?

How did you verify/test it

Run test on t0 and t1 topo.
snmp/test_snmp_v2mib.py::test_snmp_v2mib PASSED

Any platform specific information?

SONiC.master.117-dirty-20210207.073945
Distribution: Debian 10.8
Kernel: 4.19.0-9-2-amd64
Build commit: 3cc55154
Build date: Sun Feb  7 07:55:17 UTC 2021
Platform: x86_64-arista_7170_64c
HwSKU: Arista-7170-64C

Supported testbed topology if it's a new test case?

Supports any topo.

Documentation

Signed-off-by: Andrii-Yosafat Lozovyi <[email protected]>
@AndriiLozovyi AndriiLozovyi requested review from wangxin, yxieca and a team as code owners February 9, 2021 13:29
]


def test_snmp_v2mib(duthosts, rand_one_dut_hostname, localhost, creds):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have snmp tests, do you know which tests are not covered by existing tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan I didn't find test that would cover snmp sysDescr MIB, also I added verification of sysName, sysLocation and sysContact MIBs.

@AndriiLozovyi
Copy link
Contributor Author

@yxieca @wangxin could you please take a look?

@yxieca
Copy link
Collaborator

yxieca commented Feb 16, 2021

/Azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca
Copy link
Collaborator

yxieca commented Feb 17, 2021

/Azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca merged commit 06424e9 into sonic-net:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants