[dualtor]: Add utilities for dual ToR mocking #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Apply config DB tables to mock dual ToR setup * Apply kernel configurations (neighbor entries and route) * Apply orchagent config to mock dual ToR setup Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
prsunny
approved these changes
Feb 10, 2021
| ''' | ||
|
|
||
| dut = duthosts[rand_one_dut_hostname] | ||
| lo_facts = dut.get_running_config_facts()['LOOPBACK_INTERFACE'] |
There was a problem hiding this comment.
Just to confirm, is this picking up Loopback0 ip?
There was a problem hiding this comment.
Just whichever is listed first. If the config came from a minigraph generated by sonic-mgmt, it will always be Loopback0. Also, the single ToR config only has a single Loopback interface regardless.
* Use `ip * replace` instead of `add` and `delete` * Make variable names better Signed-off-by: Lawrence Lee <[email protected]>
|
This pull request introduces 1 alert when merging 08c44be into ad98413 - view on LGTM.com new alerts:
|
Signed-off-by: Lawrence Lee <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee [email protected]
Description of PR
Summary:
Closes #2808
Type of change
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation