-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BGP Allow List test case #2911
Conversation
Signed-off-by: Abhishek Dosi <[email protected]>
This pull request introduces 1 alert when merging 5e82113 into f19c4c8 - view on LGTM.com new alerts:
|
@abdosi please fix the lgtm issue |
Signed-off-by: Abhishek Dosi <[email protected]>
tested on master. |
can you add this test to kvmtest.sh t1-lag test suite, i'd like to have this test running per pr. |
Signed-off-by: Abhishek Dosi <[email protected]>
@lguohan Done |
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
i do not quite understand why it fails, i tested it locally with master image. @abdosi , is it expected? @lguohan Once this merged sonic-net/sonic-buildimage#6671 it will pass. It is new case I added today
|
@wangxin can you please approve this |
Fix sonic-net/sonic-buildimage#6572
What/Why I did:
then test case to verify with prefix list programmed with action as permit and deny
How I verify:
201911 image is passing with this change.
adosi@624e49377782:/var/src/Networking-acs-sonic-mgmt/tests$ py.test --inventory "../ansible/str,../ansible/veos" --host-pattern str-xxxx-on-2 --module-path "../ansible/library/" --testbed vms13-5-t1-lag --testbed_file "../ansible/testbed.csv" --log-cli-level info -ra -vvv "bgp/test_bgp_allow_list.py" --skip_sanity