Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BGP Allow List test case #2911

Merged
merged 5 commits into from
Feb 5, 2021
Merged

Update BGP Allow List test case #2911

merged 5 commits into from
Feb 5, 2021

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Feb 3, 2021

Fix sonic-net/sonic-buildimage#6572

What/Why I did:

How I verify:

201911 image is passing with this change.

adosi@624e49377782:/var/src/Networking-acs-sonic-mgmt/tests$ py.test --inventory "../ansible/str,../ansible/veos" --host-pattern str-xxxx-on-2 --module-path "../ansible/library/" --testbed vms13-5-t1-lag --testbed_file "../ansible/testbed.csv" --log-cli-level info -ra -vvv "bgp/test_bgp_allow_list.py" --skip_sanity

Signed-off-by: Abhishek Dosi <[email protected]>
@abdosi abdosi requested a review from a team as a code owner February 3, 2021 03:29
@abdosi abdosi changed the title Fix BGP Allow List test case Update BGP Allow List test case Feb 3, 2021
@abdosi abdosi requested a review from wangxin February 3, 2021 03:31
@lgtm-com
Copy link

lgtm-com bot commented Feb 3, 2021

This pull request introduces 1 alert when merging 5e82113 into f19c4c8 - view on LGTM.com

new alerts:

  • 1 for Unused import

@yxieca
Copy link
Collaborator

yxieca commented Feb 3, 2021

@abdosi please fix the lgtm issue

Signed-off-by: Abhishek Dosi <[email protected]>
@abdosi
Copy link
Contributor Author

abdosi commented Feb 3, 2021

@abdosi please fix the lgtm issue

@yxieca thanks !! done

@lguohan
Copy link
Contributor

lguohan commented Feb 3, 2021

tested on master.

@lguohan
Copy link
Contributor

lguohan commented Feb 3, 2021

can you add this test to kvmtest.sh t1-lag test suite, i'd like to have this test running per pr.

@abdosi
Copy link
Contributor Author

abdosi commented Feb 3, 2021

can you add this test to kvmtest.sh t1-lag test suite, i'd like to have this test running per pr.

can you add this test to kvmtest.sh t1-lag test suite, i'd like to have this test running per pr.

@lguohan Done

@lguohan
Copy link
Contributor

lguohan commented Feb 4, 2021

i do not quite understand why it fails, i tested it locally with master image. @abdosi , is it expected?

@lguohan Once this merged sonic-net/sonic-buildimage#6671 it will pass. It is new case I added today

FAILED bgp/test_bgp_allow_list.py::TestBGPAllowListBase::test_default_allow_list_postconfig

@abdosi
Copy link
Contributor Author

abdosi commented Feb 4, 2021

@wangxin can you please approve this

@abdosi abdosi merged commit 46c603b into sonic-net:master Feb 5, 2021
@abdosi abdosi deleted the allow_list branch February 5, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected routes advertised to BGP neighbors with empty allow list
4 participants