-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse platform.json, hwsku.json for generate minigraph #2887
Conversation
@jleveque @theasianpianist , the change looks good to me. Can you guys also take a look? |
Please use the testmg.sh script to verify your changes. |
@dmytroxshevchuk I need to revert this PR. We found following issue with platform.json as grant truth: For example, on a Mellanox 2700 device, if we want to deploy the 100G topology: The platform.json's alias table: ept1a would be used for Ethernet0's alias and that causes minigraph generation error. With non-breakout topologies, the alias should be etp1. |
@yxieca issue with platform.json was fixed in sonic-buildimage |
Description of PR
After transition from port_config.ini to platform.json, hwsku.json, we can`t fully deprecate and remove port_config.ini cause of port_mgmt/ansible use port_config.ini for generate minigraph. So currently we have configuration(platform.json, hwsku.json) using by sonic for configure ports and configuration(port_config.ini) using by sonic_mgmt for generate minigraph. So changes in platform.json and hwsku.json will not affect minigraph because of port_config.ini so we have configuration mismatch.
PR add functionality to sonic_mgmt for parse platform.json and hwsku.json and use this configuration for generation minigraph.
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
How did you do it?
Add functionality for parsing platform.json, hwsku.json and use this configuration for generate minigraph.
How did you verify/test it?
Compare generated minigraph/config_db configurations with platform.json, hwsku.json.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation