[pfc] Refactor pfc pause test to use existing libs and code cleanup

[neethajohn]

Signed-off-by: Neetha John [email protected]

Description of PR

This PR contains the following changes

• Refactor pfc pause test to use existing helpers for storm generation
• Enumerate testcase based on priorities for easier debugging
• Collect all errors and assert at the end to allow test to run on all background priorities
• Added a debug option in ptftests to allow captured packets to be dumped into a file for post test analysis
• Cleanup trailing white spaces

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

How did you verify/test it?

Ran the test with the changes on Th and it passed

[lgtm-com]

This pull request introduces 2 alerts and fixes 3 when merging 75277e2 into 2f0b561 - view on LGTM.com

new alerts:

• 1 for Unused local variable
• 1 for Unused import

fixed alerts:

• 3 for Unused import

[lgtm-com]

This pull request introduces 1 alert and fixes 3 when merging 38e7524 into 15793fb - view on LGTM.com

new alerts:

• 1 for Unused import

fixed alerts:

• 3 for Unused import

[yxieca]

retest vsimage please

[yxieca]

/Azurepipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[lgtm-com]

This pull request introduces 1 alert and fixes 3 when merging 64b2de1 into 856c106 - view on LGTM.com

new alerts:

• 1 for Unused import

fixed alerts:

• 3 for Unused import

[lgtm-com]

This pull request fixes 3 alerts when merging 0d155a1 into 856c106 - view on LGTM.com

fixed alerts:

• 3 for Unused import