Update console connection tool #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Refactor code 2. Support interactive_shell Signed-off-by: bingwang <[email protected]>
bingwang-ms
force-pushed
the
update_console_connection
branch
from
d00b4a9 to
fca2f03
Compare
Signed-off-by: bingwang <[email protected]>
Signed-off-by: bingwang <[email protected]>
|
This pull request introduces 3 alerts when merging 3ef5fb2 into 65c3293 - view on LGTM.com new alerts:
|
Signed-off-by: bingwang <[email protected]>
yxieca
reviewed
Jan 19, 2021
| @@ -81,3 +89,30 @@ def cleanup(self): | |||
| def disconnect(self): | |||
| super(BaseConsoleConn, self).disconnect() | |||
|
|
|||
| def posix_shell(self): | |||
There was a problem hiding this comment.
You probably can abstract this posix_shell() method out to a more generic class so that you can use it in your devutil change too?
yxieca
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang [email protected]
Description of PR
Summary:
This PR updates console connection tool
Move most code from
__init__.pytoconsole_host.pyAdd a new interactice
posix_shellfordevutilsType of change
Approach
What is the motivation for this PR?
This PR is to update console connection tool.
How did you do it?
Please see Summary.
How did you verify/test it?
Verified on various
consoleservers.Any platform specific information?
No.
Supported testbed topology if it's a new test case?
No.
Documentation