Implenemt playbook to recover vmhost server automatically #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduced several playbook to recover vmhost server automatically. Signed-off-by: bingwang <[email protected]>
Signed-off-by: bingwang <[email protected]>
bingwang-ms
force-pushed
the
recover_server
branch
from
00d562b to
c4b7e5a
Compare
Signed-off-by: bingwang <[email protected]>
bingwang-ms
changed the title
lolyu
reviewed
Jan 19, 2021
| src_disk_image: "{{ home_path }}/{{ root_path }}/images/{{ hdd_image_filename }}" | ||
| disk_image: "{{ home_path }}/{{ root_path }}/disks/{{ vm_name }}_hdd.vmdk" | ||
| cdrom_image: "{{ home_path }}/{{ root_path }}/images/{{ cd_image_filename }}" | ||
| when: '"kickstart_code" in kickstart_output and kickstart_output.kickstart_code != 0' |
There was a problem hiding this comment.
Since almost all tasks in respin_vm.yml needs escalated privilege, it will be nicer to apply become like:
- name: Respin failed vm
include_tasks: respin_vm.yml
vars:
src_disk_image: "{{ home_path }}/{{ root_path }}/images/{{ hdd_image_filename }}"
disk_image: "{{ home_path }}/{{ root_path }}/disks/{{ vm_name }}_hdd.vmdk"
cdrom_image: "{{ home_path }}/{{ root_path }}/images/{{ cd_image_filename }}"
apply:
become: True
when: '"kickstart_code" in kickstart_output and kickstart_output.kickstart_code != 0'https://docs.ansible.com/ansible/latest/collections/ansible/builtin/include_tasks_module.html
| # This playbook will cleanup a vm_host, including removing all veos, containers and net bridges. | ||
|
|
||
| - hosts: servers:&vm_host | ||
| gather_facts: no |
There was a problem hiding this comment.
Same as above to put become here.
bingwang-ms
force-pushed
the
recover_server
branch
from
11bad96 to
9f6186b
Compare
wangxin
reviewed
Jan 29, 2021
| set_fact: | ||
| kickstart_failed_vms: "{{ kickstart_failed_vms + [vm_name] }}" | ||
| when: '"kickstart_code" in kickstart_output_final and kickstart_output_final.kickstart_code != 0' | ||
| when: '"kickstart_code" in kickstart_output and kickstart_output.kickstart_code != 0' |
There was a problem hiding this comment.
Is it possible to retry respine if one round of respine still failed? To avoid endless retry, we can add a max retry limitation, like 3 times?
There was a problem hiding this comment.
Good suggestion. I'll make this change in next PR.
wangxin
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang [email protected]
Description of PR
Summary:
Fixes # (issue)
This commit introduced several playbook to recover vmhost server automatically.
It's extremely time consuming to redeploy all testbeds on a host server if the server is down or rebooted. This PR adds a new option in
testbed-cli.shto do a cleanup of host server, and adds a respin of vm that failed to start.Type of change
Approach
What is the motivation for this PR?
This PR is to add new playbooks to support auto testbed recovery.
How did you do it?
How did you verify/test it?
Verified in starlab.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
No.
Documentation