-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the fib test to support DualToR #2740
Conversation
This pull request introduces 4 alerts and fixes 2 when merging 55b1d6acd7bd121100f7220dba75ed27a267262a into 985eec2 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 2 when merging 7be5f75ddc31defdd5d5e0b945e36d5542b02203 into 077f148 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 4 alerts and fixes 2 when merging 82701f5 into 182b6d3 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request fixes 2 alerts when merging dbe3d12 into 182b6d3 - view on LGTM.com fixed alerts:
|
@@ -11,6 +11,9 @@ | |||
|
|||
logger = logging.getLogger(__name__) | |||
|
|||
UPPER_TOR = 'upper_tor' | |||
LOWER_TOR = 'lower_tor' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking this PR.
can we define these at a shared place? (next file also have them defined).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I'll address this in separate PR.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Update the FIB test to support the DualToR topology.
How did you do it?
Changes:
ptf_test_port_map
and dump it toptfhost
. Then pass the file location to PTF script as argument ofptf_runner
. Keys of the map is enabled PTF port index (T0 topologies have disabled ports). Value is a diction with two keys:target_dut
andtarget_mac
.target_dut
is index of the mux active side DUT in case of dualtor. For non-dualtor, thetarget_dut
is always 0.target_mac
is MAC address of the active side DUT. In case of dualtor, specifically it is the VLAN interface's MAC address if the PTF port is connected to VLAN port of DUT. Otherwise, it is just the router MAC.rand_one_hostname
fixture).collect_techsupport
. The reason is that thecollect_techsupport
fixture depends on the 'enum_dut_hostname` fixture. As a result, all test cases in this script will be parameterized by all the available DUTs.How did you verify/test it?
Test run the script on t0, t1-lag, dualtor topology.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation