Copp infra enhancement to support multi-asic #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 4, 2020 01:42
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
dtallen97
approved these changes
Dec 5, 2020
daall
approved these changes
Dec 5, 2020
|
This pull request introduces 2 alerts when merging 14bceb6 into 806348a - view on LGTM.com new alerts:
|
Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
added a commit
that referenced
this pull request
Mar 12, 2021
This is PR continuation of #2627 where infra changes were done to support copp on multi-asic platforms. In this PR test is enhanced to work on multi-asic platforms. Following are major changes: Multi-asic as of now will support installing of nanomsg and ptf_nn_agent in syncd directly mode. This way test case will randomly select any front-asic syncd for verification. To support this needed to add iptable rules for HTTP and PTF Traffic forwarding from host to asic namespace. swap_syncd mode is not supported as of now. All the docker name are translated to particular namespace/asic that is under test. (Added utility api for same). Remove disable_lldp_for_testing fixture as noted below since test case is not dependent on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why I did:-
Copp test case infrastructure enhanced to support multi-asic (Subsequent PR's). Following changes are done:
Removed the default "nn_target_port" and option to pass this. Instead of this the "nn_target_port" is selected randomly.
Randomization helps in multi-asic where we can cover multiple asic across test-runs
Also removed passing bgp facts to ptf tests. Without this it is very difficult to run ptf test manually. Instead now peer_ip/my_ip is found in the test itself and pass to the ptf tests. This also helps to find asic the peer is connected.
How I Verify: