Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BGP] Implement new testcase test_traffic_shift #2553
[BGP] Implement new testcase test_traffic_shift #2553
Changes from 4 commits
29ba584
9e91614
c3f2fba
f2e18a6
30a076a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The argument name is not dump_script, but default_dump_script
As I see it here:
https://github.com/Azure/sonic-mgmt/pull/2553/files#diff-ca868a64bc6e0673c7630841edad82bd6de93e60ea7a7ba694c87467d69c8f2eR209
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we start bgpmon before TSA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think bgpmon should be started after
TSA
. That is because if we start bgpmon, and then setTSA
, there will be a shortTSB (normal)
state between two operations, during which routes are possible to be announced. We might get a failure then.