-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of multi-DUT and multi-ASIC as per PR 2347 #2417
Conversation
This pull request introduces 3 alerts when merging bc0822d74306a3728b71f48eab59d0377da9f458 into 553e9ff - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging b76cacb7d58d33381b990a0f0d8029b323d7db9a into 928ebb3 - view on LGTM.com new alerts:
|
@sanmalho-git The last commit looks good to me. This PR would be perfect if you could:
|
… testing support - Added the classes described in the PR: - SonicAsic - represents an asic, and implements the asic/namespace related operations to hide the complexity of handling the asic/namespace specific details. - For now, have added bgp_facts as an example to add 'instance_id' to the bgp_facts module call on a SonicHost. - MutliAsicSonicHost - a host with one or more SonicAsics. - DutHosts - represents all the DUT's in a testbed. - has 'nodes' list to represent each DUT in the testbed. - Update duthosts fixture to return an instance of DutHosts instead of a list of SonicHosts - Modify duthost fixture to return a MultiAsicSonicHost from duthosts.nodes
… testing support - Added the classes described in the PR: - SonicAsic - represents an asic, and implements the asic/namespace related operations to hide the complexity of handling the asic/namespace specific details. - For now, have added bgp_facts as an example to add 'instance_id' to the bgp_facts module call on a SonicHost. - MutliAsicSonicHost - a host with one or more SonicAsics. - DutHosts - represents all the DUT's in a testbed. - has 'nodes' list to represent each DUT in the testbed. - Update duthosts fixture to return an instance of DutHosts instead of a list of SonicHosts - Modify duthost fixture to return a MultiAsicSonicHost from duthosts.nodes
b76cacb
to
09ae617
Compare
This pull request introduces 3 alerts when merging 09ae617 into 38fe987 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 0c5a647 into 38fe987 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
retest this please |
\u2026 testing support
Description of PR
Summary:
This is implementation of PR 2347 that described enhancements to support multi-asic and multi-dut
Type of change
Approach
What is the motivation for this PR?
PR sonic-net/SONiC#644 introduced the HLD to support multi ASIC. In the future, multi DUT or Chassis will be supported by SONiC as well. The test infrastructure and some of the customized ansible modules need to be updated to support testing of the upcoming new architectures. This PR is implementation of PR 2347 which tried to propose how to improve the current test infrastructure to support multi-DUT and multi-ASIC systems. The target is to ensure that the existing test scripts are not broken and we can update the tests in incremental way.
How did you do it?
Implemented the proposed classes in PR 2347.
Added the classes described in the PR:
SonicAsic - represents an asic, and implements the asic/namespace related operations to hide the complexity of handling the asic/namespace specific details.
MutliAsicSonicHost - a host with one or more SonicAsics.
DutHosts - represents all the DUT's in a testbed.
Update duthosts fixture to return an instance of DutHosts instead of a list of SonicHosts
Modify duthost fixture to return a MultiAsicSonicHost from duthosts.nodes
How did you verify/test it?
Using the newly added classes, tried out bgp_facts ansible module against:
Tested following scenarios were tested against the 4 testbed DUT's above. In the scenarios - duthosts represents a DutHosts instance. Tested with 'command' ansible module (a module that is not impacted by multi-asic), and bgp_facts (a module that has to handle differences for multi-asic)
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation