[LogAnalyzer] Ignore "sflowmgrd process is not running" warning in LogAnalyzer for master #2261
Conversation
|
Is this related to this PR sonic-net/sonic-buildimage#5153 ? |
Yes. I think so. Before the monit config is fixed, we need to ignore this error. |
| # sflowmgrd is configed in Monit, but not included in current master branch image | ||
| # So a workaround is added for master branch. Once the issue is adressed, we should | ||
| # rm this patch | ||
| if "master" in duthost.os_version: |
There was a problem hiding this comment.
os_version contains 'master' is a very specific check that only works for images built by public Jenkins and/or no tag on the latest commit. not sure if we should keep it here or ignore the event in general until the fix is in?
There was a problem hiding this comment.
What about adding a negative check?
if '201911' not in duthost.os_version:
There was a problem hiding this comment.
os_version contains 'master' is a very specific check that only works for images built by public Jenkins and/or no tag on the latest commit. not sure if we should keep it here or ignore the event in general until the fix is in?
I add the check for master intendedly because I expect this patch only work for mater branch in a few days, as PR sonic-net/sonic-buildimage#5153 will address it. Will this issue exist in next 201911 build?
There was a problem hiding this comment.
If this ignore will only be needed for a few days, maybe it is better to update the common ignore file in jenkins just before running the tests?
There was a problem hiding this comment.
Oh. That's quite a creative idea. I will apply this easy patch on Jenkins now. Thanks Xin.
|
A patch is applied on Jenkins, and no need to update code. |
Description of PR
Summary:
sflowmgrd is configured in Monit, but not included in current master branch image. As a result, there will be a warning in syslog.
To workaroud this error temporarily, this PR add a patch to ignore the pattern for master branch.
Type of change
Approach
Add a patch to ignore 'sflowmgrd' process is not running for master branch.
What is the motivation for this PR?
This PR is to ignore test errors caused by 'sflowmgrd' process is not running in syslog.
How did you do it?
Add a new pattern to ignore_list of LogAnalyzer.
How did you verify/test it?
Verified on dx010 running master branch.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
No.
Documentation
No.