[sonic-mgmt] Fix snmp/test_snmp_queue_counters.py teardown failure #15765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "enum_rand_one_per_hwsku_frontend_hostname" fixture in the "teardown" fixture to derive the duthost name being used in the "test_snmp_queue_counters" method. This fixes the issue of teardown/cleanup happening in the incorrect dut.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 27, 2024
…onic-net#15765) * [sonic-mgmt] Fix snmp/test_snmp_queue_counters.py teardown failure Use "enum_rand_one_per_hwsku_frontend_hostname" fixture in the "teardown" fixture to derive the duthost name being used in the "test_snmp_queue_counters" method. This fixes the issue of teardown/cleanup happening in the incorrect dut. * Correct function docstring to reflect function parameters.
|
Cherry-pick PR to 202405: #15769 |
Merged
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 28, 2024
…15765) * [sonic-mgmt] Fix snmp/test_snmp_queue_counters.py teardown failure Use "enum_rand_one_per_hwsku_frontend_hostname" fixture in the "teardown" fixture to derive the duthost name being used in the "test_snmp_queue_counters" method. This fixes the issue of teardown/cleanup happening in the incorrect dut. * Correct function docstring to reflect function parameters.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: [sonic-mgmt][dualtor] Fix snmp/test_snmp_queue_counters.py teardown failure
Fixes # https://github.com/aristanetworks/sonic-qual.msft/issues/340
Type of change
Back port request
Approach
What is the motivation for this PR?
teardownfixture is trying to replace config_db.json file with the original config_db.json file on the duthost (saved by thetest_snmp_queue_countersmethod before performing any config changes). But the teardown is happening on incorrect duthost (different from duthost used by the test method) and leading toSource /etc/sonic/orig_config_db.json not founderrorHow did you do it?
Use
enum_rand_one_per_hwsku_frontend_hostnamefixture in theteardownfixture to derive the duthost name (similar totest_snmp_queue_countersmethod). This fixes the issue of teardown/cleanup happening in the incorrect dut.How did you verify/test it?
Verified that test is passing with the fix on
Arista-7260CX3-D108C8Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation