Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:14942] Cisco-8122 fixes for T1 topology #15085

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Round of fixes for T1 topology for Cisco-8122 after initial test_qos_sai.py commit from PR #14334

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

T1 topologies have some background LACP and LLDP traffic entering on PG 4, making some tests unstable.

  • testQosSaiDscpToPgMapping: Revised to use Broadcom's method with an inequality to account for the excess PG4 packets. Also revised the log_message that won't print by default to be err prints.
  • Increased margin for testQosSaiPfcXoffLimit test when DSCP 4 is being tested.
  • testQosSaiQWatermarkAllPorts: Tuned leakout base value.

How did you do it?

How did you verify/test it?

Verified test_qos_sai.py full pass (18 tests) on Cisco-8122 Backend T0 and Backend T1 topologies.

Any platform specific information?

Cisco-only.

Supported testbed topology if it's a new test case?

Documentation

* Fixes for T1 topology for DscpToPg, xoff_2, and q watermark all port test cases.

* Revise log message.
@mssonicbld
Copy link
Collaborator Author

Original PR: #14942

@mssonicbld mssonicbld merged commit 420d079 into sonic-net:202405 Oct 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants