Enhance packet validation for lag member ports on VLAN ansible test. #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance packet validation for lag member ports on VLAN ansible test. Summary: Fixes #1288 It expects to receive ICMP reply packet from fixed port of lag (1st member port) on VLAN ansible test script. It shall not specify fixed port to verify, because the ICMP reply packet may come from any port of lag. Enhance packet validation for lag member ports: - vlan_info.j2 1. Add new field 'is_lag' to identify interface type. 2. Lag interface: replace 'port_index' with 'port_indices' to take all lag member ports. 3. Normal port interface: only take the port which is not lag member. - vlan_test.py 1. If the verify interface is lag, verify packets on all lag member ports. When one of lag member ports receives expected packet, the test shall be passed. 2. On test case #4, it tests ICMP routing, the DA of ICMP reply packet may equal to one of lag port interfaces on PTF server (because dut may send ARP packet from one of lag member ports). So the test shall be passed when following conditions are matched: - the ICMP reply packet is come from one of lag member port interfaces - the DA of ICMP reply packet is equal to one of lag member port's MAC Type of chang [v] Bug fix [] Testbed and Frameword(new/improvement) [] Test case(new/improvement)
|
@linemma can you rebase this PR and solve the merge conflict? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Emma Lin [email protected]
Description of PR
Enhance packet validation for lag member ports on VLAN ansible test.
Summary:
Fixes #1288
It expects to receive ICMP reply packet from fixed port of lag (1st member port) on VLAN ansible test script. It shall not specify fixed port to verify, because the ICMP reply packet may come from any port of lag.
Enhance packet validation for lag member ports:
vlan_info.j2
vlan_test.py
Type of change
Approach
How did you do it?
How did you verify/test it?
Run vlan ansible test with t0-116 topology and check the test result. No matter ICMP reply packet come from which lag member port, the test result is passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation