Fix convert_and_restore_config_db_to_ipv6_only reload config failure #13277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
load_minigraph and config reload will restart mgmt interface, working on a PR to make config command wait mgmt interface finish restart before exit: sonic-net/sonic-utilities#3365 The PR will break some IPV6 test case because the test case will remove IPV4 address from mgmt interface, after this change the duthost connection will raise "device not reachable" exception. Without above PR the fix still necessary, because the mgmt still have chance restart before config command exit and break IPV6 test case. |
5 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 14, 2024
…onic-net#13277) Fix convert_and_restore_config_db_to_ipv6_only reload config failure. Why I did it convert_and_restore_config_db_to_ipv6_only fixture will delete ipv4 mgmt address by config reload. If mgmt interface restart before config reload, the duthost class will lost connection to device and throw unreachable exception. How I did it Ignore config reload AnsibleConnectionFailure exception. How to verify it Pass all test case. Description for the changelog Fix convert_and_restore_config_db_to_ipv6_only reload config failure. co-authorized by: [email protected]
|
Cherry-pick PR to 202311: #13295 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 14, 2024
…onic-net#13277) Fix convert_and_restore_config_db_to_ipv6_only reload config failure. Why I did it convert_and_restore_config_db_to_ipv6_only fixture will delete ipv4 mgmt address by config reload. If mgmt interface restart before config reload, the duthost class will lost connection to device and throw unreachable exception. How I did it Ignore config reload AnsibleConnectionFailure exception. How to verify it Pass all test case. Description for the changelog Fix convert_and_restore_config_db_to_ipv6_only reload config failure. co-authorized by: [email protected]
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 14, 2024
…onic-net#13277) Fix convert_and_restore_config_db_to_ipv6_only reload config failure. Why I did it convert_and_restore_config_db_to_ipv6_only fixture will delete ipv4 mgmt address by config reload. If mgmt interface restart before config reload, the duthost class will lost connection to device and throw unreachable exception. How I did it Ignore config reload AnsibleConnectionFailure exception. How to verify it Pass all test case. Description for the changelog Fix convert_and_restore_config_db_to_ipv6_only reload config failure. co-authorized by: [email protected]
Merged
9 tasks
|
Cherry-pick PR to 202305: #13296 |
|
Cherry-pick PR to 202405: #13297 |
This was referenced Jun 14, 2024
Merged
mssonicbld
pushed a commit
that referenced
this pull request
Jun 14, 2024
…13277) Fix convert_and_restore_config_db_to_ipv6_only reload config failure. Why I did it convert_and_restore_config_db_to_ipv6_only fixture will delete ipv4 mgmt address by config reload. If mgmt interface restart before config reload, the duthost class will lost connection to device and throw unreachable exception. How I did it Ignore config reload AnsibleConnectionFailure exception. How to verify it Pass all test case. Description for the changelog Fix convert_and_restore_config_db_to_ipv6_only reload config failure. co-authorized by: [email protected]
mssonicbld
pushed a commit
that referenced
this pull request
Jun 14, 2024
…13277) Fix convert_and_restore_config_db_to_ipv6_only reload config failure. Why I did it convert_and_restore_config_db_to_ipv6_only fixture will delete ipv4 mgmt address by config reload. If mgmt interface restart before config reload, the duthost class will lost connection to device and throw unreachable exception. How I did it Ignore config reload AnsibleConnectionFailure exception. How to verify it Pass all test case. Description for the changelog Fix convert_and_restore_config_db_to_ipv6_only reload config failure. co-authorized by: [email protected]
mssonicbld
pushed a commit
that referenced
this pull request
Jun 14, 2024
…13277) Fix convert_and_restore_config_db_to_ipv6_only reload config failure. Why I did it convert_and_restore_config_db_to_ipv6_only fixture will delete ipv4 mgmt address by config reload. If mgmt interface restart before config reload, the duthost class will lost connection to device and throw unreachable exception. How I did it Ignore config reload AnsibleConnectionFailure exception. How to verify it Pass all test case. Description for the changelog Fix convert_and_restore_config_db_to_ipv6_only reload config failure. co-authorized by: [email protected]
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
9 tasks
yejianquan
pushed a commit
that referenced
this pull request
Jun 14, 2024
Fix import AnsibleConnectionFailure from ansible.errors issue. Why I did it In ansible the AnsibleConnectionFailure defined in 2 place: pytest_ansible.errors ansible.errors In this PR: #13277 The code should import the pytest_ansible.errors.AnsibleConnectionFailure How I did it Import AnsibleConnectionFailure from pytest_ansible.errors How to verify it Pass all test case. co-authorized by: [email protected]
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 18, 2024
Fix import AnsibleConnectionFailure from ansible.errors issue. Why I did it In ansible the AnsibleConnectionFailure defined in 2 place: pytest_ansible.errors ansible.errors In this PR: sonic-net#13277 The code should import the pytest_ansible.errors.AnsibleConnectionFailure How I did it Import AnsibleConnectionFailure from pytest_ansible.errors How to verify it Pass all test case. co-authorized by: [email protected]
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 18, 2024
Fix import AnsibleConnectionFailure from ansible.errors issue. Why I did it In ansible the AnsibleConnectionFailure defined in 2 place: pytest_ansible.errors ansible.errors In this PR: sonic-net#13277 The code should import the pytest_ansible.errors.AnsibleConnectionFailure How I did it Import AnsibleConnectionFailure from pytest_ansible.errors How to verify it Pass all test case. co-authorized by: [email protected]
9 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 18, 2024
Fix import AnsibleConnectionFailure from ansible.errors issue. Why I did it In ansible the AnsibleConnectionFailure defined in 2 place: pytest_ansible.errors ansible.errors In this PR: sonic-net#13277 The code should import the pytest_ansible.errors.AnsibleConnectionFailure How I did it Import AnsibleConnectionFailure from pytest_ansible.errors How to verify it Pass all test case. co-authorized by: [email protected]
This was referenced Jun 18, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Jun 18, 2024
Fix import AnsibleConnectionFailure from ansible.errors issue. Why I did it In ansible the AnsibleConnectionFailure defined in 2 place: pytest_ansible.errors ansible.errors In this PR: #13277 The code should import the pytest_ansible.errors.AnsibleConnectionFailure How I did it Import AnsibleConnectionFailure from pytest_ansible.errors How to verify it Pass all test case. co-authorized by: [email protected]
mssonicbld
pushed a commit
that referenced
this pull request
Jun 18, 2024
Fix import AnsibleConnectionFailure from ansible.errors issue. Why I did it In ansible the AnsibleConnectionFailure defined in 2 place: pytest_ansible.errors ansible.errors In this PR: #13277 The code should import the pytest_ansible.errors.AnsibleConnectionFailure How I did it Import AnsibleConnectionFailure from pytest_ansible.errors How to verify it Pass all test case. co-authorized by: [email protected]
mssonicbld
pushed a commit
that referenced
this pull request
Jun 18, 2024
Fix import AnsibleConnectionFailure from ansible.errors issue. Why I did it In ansible the AnsibleConnectionFailure defined in 2 place: pytest_ansible.errors ansible.errors In this PR: #13277 The code should import the pytest_ansible.errors.AnsibleConnectionFailure How I did it Import AnsibleConnectionFailure from pytest_ansible.errors How to verify it Pass all test case. co-authorized by: [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix convert_and_restore_config_db_to_ipv6_only reload config failure.
Why I did it
convert_and_restore_config_db_to_ipv6_only fixture will delete ipv4 mgmt address by config reload.
If mgmt interface restart before config reload, the duthost class will lost connection to device and throw unreachable exception.
How I did it
Ignore config reload AnsibleConnectionFailure exception.
How to verify it
Pass all test case.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Fix convert_and_restore_config_db_to_ipv6_only reload config failure.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)