-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some tests to verify Redis DB configuration #12877
Conversation
Add a test script to check that the redis config for the save setting is correct. This can be extended to check for other config options. Signed-off-by: Saikrishna Arcot <[email protected]>
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
/azp run Azure.sonic-mgmt |
Commenter does not have sufficient privileges for PR 12877 in repo sonic-net/sonic-mgmt |
/azpw run Azure.sonic-mgmt |
/AzurePipelines run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
@saiarcot895 Do we need this PR for release branch? |
Description of PR
Add a test script to check that the redis config for the save setting, database count, and unix socket are correct. This can be extended to check for other config options.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
This is in response to sonic-net/sonic-buildimage#18979 and sonic-net/sonic-buildimage#18108, where with the database container upgrade to Bookworm, redis DB was configured to save to disk by default. This then caused issues in multi-ASIC setups.
How did you do it?
How did you verify/test it?
Tested on T0 KVM with sonic-net/sonic-buildimage#18979 applied.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation