Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drop_packets/test_configurable_drop_counters.py for active-active dualtor. #12500

Merged

Conversation

vivekverma-arista
Copy link
Contributor

Description of PR

Summary:
Fixes #

  1. https://github.com/aristanetworks/sonic-qual.msft/issues/95
  2. https://github.com/aristanetworks/sonic-qual.msft/issues/93

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

Testcases fail in drop_packets/test_configurable_drop_counters.py fail in dualtor-aa because some of the traffic goes to the unselected ToR.

How did you do it?

Similar approach is taken as in #11921

How did you verify/test it?

Verified on Arista 7260 and Arista 7050 with both dualtor and dualtor-aa topology.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@vivekverma-arista vivekverma-arista changed the title Fix drop_packets/test_configurable_drop_counters.py Fix drop_packets/test_configurable_drop_counters.py for active-active dualtor. Apr 18, 2024
@StormLiangMS StormLiangMS requested a review from lolyu April 19, 2024 04:20
@StormLiangMS
Copy link
Collaborator

hi @lolyu @theasianpianist could you help to take a look?

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit eec9eff into sonic-net:master Apr 26, 2024
13 checks passed
@StormLiangMS
Copy link
Collaborator

hi @vivekverma-arista could you confirm if tested with 202305/202311 image?

@vivekverma-arista
Copy link
Contributor Author

vivekverma-arista commented Apr 26, 2024

This has been tested with 202305 and 202311 image @StormLiangMS

@vivekverma-arista vivekverma-arista deleted the test-config-drop-counter-fix branch April 26, 2024 11:36
@StormLiangMS
Copy link
Collaborator

hi @vivekverma-arista could you confirm the result with T0 / T1 topo for this change?

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request May 16, 2024
Testcases fail in drop_packets/test_configurable_drop_counters.py fail in dualtor-aa because some of the traffic goes to the unselected ToR.

How did you do it?
Similar approach is taken as in sonic-net#11921

How did you verify/test it?
Verified on Arista 7260 and Arista 7050 with both dualtor and dualtor-aa topology.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #12865

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request May 16, 2024
Testcases fail in drop_packets/test_configurable_drop_counters.py fail in dualtor-aa because some of the traffic goes to the unselected ToR.

How did you do it?
Similar approach is taken as in sonic-net#11921

How did you verify/test it?
Verified on Arista 7260 and Arista 7050 with both dualtor and dualtor-aa topology.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #12866

mssonicbld pushed a commit that referenced this pull request May 16, 2024
Testcases fail in drop_packets/test_configurable_drop_counters.py fail in dualtor-aa because some of the traffic goes to the unselected ToR.

How did you do it?
Similar approach is taken as in #11921

How did you verify/test it?
Verified on Arista 7260 and Arista 7050 with both dualtor and dualtor-aa topology.
mssonicbld pushed a commit that referenced this pull request May 16, 2024
Testcases fail in drop_packets/test_configurable_drop_counters.py fail in dualtor-aa because some of the traffic goes to the unselected ToR.

How did you do it?
Similar approach is taken as in #11921

How did you verify/test it?
Verified on Arista 7260 and Arista 7050 with both dualtor and dualtor-aa topology.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants