-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_telemetry:test_osbuild_version to use correct SONiC string in OS version #11958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganglyu
approved these changes
Mar 18, 2024
wangxin
approved these changes
Mar 18, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 22, 2024
…n OS version (sonic-net#11958) What is the motivation for this PR? Need to make corresponding change done in sonic-net/sonic-gnmi#190 to sonic-mgmt test case How did you do it? Fix expected sonic string in test case How did you verify/test it? Pipeline
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 22, 2024
…n OS version (sonic-net#11958) What is the motivation for this PR? Need to make corresponding change done in sonic-net/sonic-gnmi#190 to sonic-mgmt test case How did you do it? Fix expected sonic string in test case How did you verify/test it? Pipeline
Cherry-pick PR to 202311: #12125 |
Cherry-pick PR to 202305: #12126 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 22, 2024
…n OS version (#11958) What is the motivation for this PR? Need to make corresponding change done in sonic-net/sonic-gnmi#190 to sonic-mgmt test case How did you do it? Fix expected sonic string in test case How did you verify/test it? Pipeline
mssonicbld
pushed a commit
that referenced
this pull request
Mar 22, 2024
…n OS version (#11958) What is the motivation for this PR? Need to make corresponding change done in sonic-net/sonic-gnmi#190 to sonic-mgmt test case How did you do it? Fix expected sonic string in test case How did you verify/test it? Pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue) 25377424
Type of change
Back port request
Approach
What is the motivation for this PR?
Need to make corresponding change done in sonic-net/sonic-gnmi#190 to sonic-mgmt test case
How did you do it?
Fix expected sonic string in test case
How did you verify/test it?
Pipeline
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation