Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_telemetry:test_osbuild_version to use correct SONiC string in OS version #11958

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

zbud-msft
Copy link
Contributor

@zbud-msft zbud-msft commented Mar 12, 2024

Description of PR

Summary:
Fixes # (issue) 25377424

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

Need to make corresponding change done in sonic-net/sonic-gnmi#190 to sonic-mgmt test case

How did you do it?

Fix expected sonic string in test case

How did you verify/test it?

Pipeline

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wangxin wangxin merged commit a3ba261 into sonic-net:master Mar 18, 2024
12 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 22, 2024
…n OS version (sonic-net#11958)

What is the motivation for this PR?
Need to make corresponding change done in sonic-net/sonic-gnmi#190 to sonic-mgmt test case

How did you do it?
Fix expected sonic string in test case

How did you verify/test it?
Pipeline
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 22, 2024
…n OS version (sonic-net#11958)

What is the motivation for this PR?
Need to make corresponding change done in sonic-net/sonic-gnmi#190 to sonic-mgmt test case

How did you do it?
Fix expected sonic string in test case

How did you verify/test it?
Pipeline
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #12125

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #12126

mssonicbld pushed a commit that referenced this pull request Mar 22, 2024
…n OS version (#11958)

What is the motivation for this PR?
Need to make corresponding change done in sonic-net/sonic-gnmi#190 to sonic-mgmt test case

How did you do it?
Fix expected sonic string in test case

How did you verify/test it?
Pipeline
mssonicbld pushed a commit that referenced this pull request Mar 22, 2024
…n OS version (#11958)

What is the motivation for this PR?
Need to make corresponding change done in sonic-net/sonic-gnmi#190 to sonic-mgmt test case

How did you do it?
Fix expected sonic string in test case

How did you verify/test it?
Pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants