Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dhcp_server] Add test plan for dhcp_server #11348

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

yaqiangz
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

Add test plan for dhcp_server

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@yaqiangz yaqiangz force-pushed the azure-master_dhcp_server_test_plan branch from 0e72ee0 to 4706e35 Compare January 19, 2024 07:21
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing docs/testplan/IPv4-Port-Based-DHCP-Server-test-plan.md

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@yaqiangz yaqiangz requested a review from Blueve January 22, 2024 02:44
@yaqiangz yaqiangz force-pushed the azure-master_dhcp_server_test_plan branch 2 times, most recently from f905efd to 7134f6e Compare January 25, 2024 10:15
@yaqiangz yaqiangz requested a review from Blueve January 30, 2024 06:01
@yaqiangz yaqiangz force-pushed the azure-master_dhcp_server_test_plan branch from 7134f6e to 0c2965a Compare March 11, 2024 04:24
@yaqiangz yaqiangz force-pushed the azure-master_dhcp_server_test_plan branch from 332e6d8 to 5bcbb5c Compare March 11, 2024 04:35
@yaqiangz
Copy link
Contributor Author

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaqiangz
Copy link
Contributor Author

@wangxin Could you help to merge this PR?

@wangxin wangxin merged commit e238067 into sonic-net:master Mar 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants