Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config bgp bbr by GCU cmd in test_bgp_bbr test #11223

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

Gfrom2016
Copy link
Contributor

@Gfrom2016 Gfrom2016 commented Jan 9, 2024

Description of PR

Summary:
Fixes # (issue)
Config bbr status by using GCU cmd since we enable YANG model for bbr in sonic-net/sonic-buildimage#17622.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

Config bbr status by GCU cmd.

How did you do it?

Config bbr status use cmd config apply-patch <json-patch> instead of sonic-cfggen

How did you verify/test it?

Run bgp/test_bgp_bbr.py case on dut manually and passed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: zitingguo <[email protected]>
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/bgp/test_bgp_bbr.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: zitingguo-ms <[email protected]>
@Gfrom2016 Gfrom2016 changed the title config bbr by GCU cmd in test_bgp_bbr test Config bgp bbr by GCU cmd in test_bgp_bbr test Jan 9, 2024
@Gfrom2016 Gfrom2016 marked this pull request as ready for review January 9, 2024 09:39
Signed-off-by: zitingguo-ms <[email protected]>
Signed-off-by: zitingguo-ms <[email protected]>
Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 2319f3c into sonic-net:master Jan 11, 2024
13 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 11, 2024
What is the motivation for this PR?
Config bbr status by GCU cmd.

How did you do it?
Config bbr status use cmd config apply-patch <json-patch> instead of sonic-cfggen

How did you verify/test it?
Run bgp/test_bgp_bbr.py case on dut manually and passed.
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 11, 2024
What is the motivation for this PR?
Config bbr status by GCU cmd.

How did you do it?
Config bbr status use cmd config apply-patch <json-patch> instead of sonic-cfggen

How did you verify/test it?
Run bgp/test_bgp_bbr.py case on dut manually and passed.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #11247

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #11248

mssonicbld pushed a commit that referenced this pull request Jan 11, 2024
What is the motivation for this PR?
Config bbr status by GCU cmd.

How did you do it?
Config bbr status use cmd config apply-patch <json-patch> instead of sonic-cfggen

How did you verify/test it?
Run bgp/test_bgp_bbr.py case on dut manually and passed.
mssonicbld pushed a commit that referenced this pull request Jan 11, 2024
What is the motivation for this PR?
Config bbr status by GCU cmd.

How did you do it?
Config bbr status use cmd config apply-patch <json-patch> instead of sonic-cfggen

How did you verify/test it?
Run bgp/test_bgp_bbr.py case on dut manually and passed.
@Gfrom2016 Gfrom2016 deleted the modify_bbr_case branch August 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants