-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config bgp bbr by GCU cmd in test_bgp_bbr test #11223
Conversation
Signed-off-by: zitingguo <[email protected]>
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
Signed-off-by: zitingguo-ms <[email protected]>
Signed-off-by: zitingguo-ms <[email protected]>
Signed-off-by: zitingguo-ms <[email protected]>
Signed-off-by: zitingguo-ms <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the motivation for this PR? Config bbr status by GCU cmd. How did you do it? Config bbr status use cmd config apply-patch <json-patch> instead of sonic-cfggen How did you verify/test it? Run bgp/test_bgp_bbr.py case on dut manually and passed.
What is the motivation for this PR? Config bbr status by GCU cmd. How did you do it? Config bbr status use cmd config apply-patch <json-patch> instead of sonic-cfggen How did you verify/test it? Run bgp/test_bgp_bbr.py case on dut manually and passed.
Cherry-pick PR to 202311: #11247 |
Cherry-pick PR to 202305: #11248 |
What is the motivation for this PR? Config bbr status by GCU cmd. How did you do it? Config bbr status use cmd config apply-patch <json-patch> instead of sonic-cfggen How did you verify/test it? Run bgp/test_bgp_bbr.py case on dut manually and passed.
What is the motivation for this PR? Config bbr status by GCU cmd. How did you do it? Config bbr status use cmd config apply-patch <json-patch> instead of sonic-cfggen How did you verify/test it? Run bgp/test_bgp_bbr.py case on dut manually and passed.
Description of PR
Summary:
Fixes # (issue)
Config bbr status by using GCU cmd since we enable YANG model for bbr in sonic-net/sonic-buildimage#17622.
Type of change
Back port request
Approach
What is the motivation for this PR?
Config bbr status by GCU cmd.
How did you do it?
Config bbr status use cmd
config apply-patch <json-patch>
instead ofsonic-cfggen
How did you verify/test it?
Run bgp/test_bgp_bbr.py case on dut manually and passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation