Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:11160] [dualtor] use 'get_pdu_controller' to ensure same dut in test_power_off_reboot #11201

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

#8646 made a change in fixture 'pdu_controller' to always choose supervisor if device is chassis, for non-chassis it'll choose a random dut. PR 8646 will work in the same way for single-dut, but for dualtor, the randomly chosen dut could be different dut than the one under testing.

This PR call 'get_pdu_controller' to ensure pdu_controller is getting on the same dut.

There is no generic fix for this scenario that use "enum_supervisor_dut_hostname" for both tests and fixture pdu_controller, because platform_tests/conftest.py have a autouse fixture skip_on_simx that makes all platform tests use rand_one_dut_hostname.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator Author

Original PR: #11160

@mssonicbld mssonicbld merged commit e7e3cb0 into sonic-net:202305 Jan 5, 2024
12 checks passed
@mssonicbld mssonicbld deleted the cherry/202305/11160 branch February 4, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants