-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[container hardening] include multiasic scenario, add lldp and teamd containers to testcase #10070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mai Bui <[email protected]>
Signed-off-by: Mai Bui <[email protected]>
qiluo-msft
reviewed
Sep 20, 2023
qiluo-msft
previously approved these changes
Sep 20, 2023
Signed-off-by: Mai Bui <[email protected]>
Signed-off-by: Mai Bui <[email protected]>
SuvarnaMeenakshi
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/azp run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Include multiasic scenario, add lldp and teamd containers to testcase
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Handle both multiasic and single asic scenarios in container hardening testcase
Add lldp and teamd containers to testcase
How did you do it?
For teamd, the pattern
df -h
is different so cannot usedf -h | grep /etc/hosts | awk '{print $1}'
to grep device./dev/vda3 16G 2.1G 14G 14% /var/warmboot
How did you verify/test it?
Manual test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation